Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Sam Protsenko
On Fri, Jul 12, 2019 at 6:49 PM Eugeniu Rosca wrote: > > On Fri, Jul 12, 2019 at 05:01:09PM +0300, Sam Protsenko wrote: > > > > diff --git a/cmd/bcb.c b/cmd/bcb.c > > > > index 2bd5a744deb5..3b1c7434e287 100644 > > > > --- a/cmd/bcb.c > > > > +++ b/cmd/bcb.c > > > > @@ -46,9 +46,6 @@ static int bc

Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Eugeniu Rosca
On Fri, Jul 12, 2019 at 05:01:09PM +0300, Sam Protsenko wrote: > > > diff --git a/cmd/bcb.c b/cmd/bcb.c > > > index 2bd5a744deb5..3b1c7434e287 100644 > > > --- a/cmd/bcb.c > > > +++ b/cmd/bcb.c > > > @@ -46,9 +46,6 @@ static int bcb_is_misused(int argc, char *const argv[]) > > > > > > switc

Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Sam Protsenko
On Fri, Jul 12, 2019 at 4:37 PM Sam Protsenko wrote: > > On Fri, Jul 12, 2019 at 3:50 PM Eugeniu Rosca wrote: > > > > Fix warning V1037 reported by PVS-Studio Static Analyzer: > > Two or more case-branches perform the same actions. Check lines: 49, 53 > > > > Fixes: db7b7a05b267 ("cmd: Add 'bcb'

Re: [U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Sam Protsenko
On Fri, Jul 12, 2019 at 3:50 PM Eugeniu Rosca wrote: > > Fix warning V1037 reported by PVS-Studio Static Analyzer: > Two or more case-branches perform the same actions. Check lines: 49, 53 > > Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields") > Signed-off-by: Eugeniu R

[U-Boot] [PATCH v2 3/5] cmd: bcb: Fix duplicated handling in two case-branches

2019-07-12 Thread Eugeniu Rosca
Fix warning V1037 reported by PVS-Studio Static Analyzer: Two or more case-branches perform the same actions. Check lines: 49, 53 Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields") Signed-off-by: Eugeniu Rosca Reviewed-by: Igor Opaniuk --- v2: - Added 'Reviewed-by: I