Re: [U-Boot] [PATCH v2 2/8] dm: serial: fix console putc

2014-10-23 Thread Simon Glass
On 23 October 2014 12:43, Simon Glass wrote: > On 23 October 2014 07:26, Masahiro Yamada wrote: >> Commit b8893327e9d2 (dm: serial: Put common code into separate functions) >> consolidated getc() correctly, but introduced another bug to putc(); >> serial_stub_putc() passes sdev->priv to serial_pu

Re: [U-Boot] [PATCH v2 2/8] dm: serial: fix console putc

2014-10-23 Thread Simon Glass
On 23 October 2014 07:26, Masahiro Yamada wrote: > Commit b8893327e9d2 (dm: serial: Put common code into separate functions) > consolidated getc() correctly, but introduced another bug to putc(); > serial_stub_putc() passes sdev->priv to serial_putc_dev(), but > serial_putc_dev() uses cur_dev inst

[U-Boot] [PATCH v2 2/8] dm: serial: fix console putc

2014-10-23 Thread Masahiro Yamada
Commit b8893327e9d2 (dm: serial: Put common code into separate functions) consolidated getc() correctly, but introduced another bug to putc(); serial_stub_putc() passes sdev->priv to serial_putc_dev(), but serial_putc_dev() uses cur_dev instead of the given argument. Signed-off-by: Masahiro Yamada