The SPL-DFU feature enable to load and
execute u-boot from RAM over usb from
PC using dfu-util.
Hence dfu-reset should not be issued
when dfu-util -R switch is issued.
Signed-off-by: Ravi Babu
---
common/dfu.c | 2 +-
common/spl/Kconfig | 4
drivers/dfu/dfu.c | 4
3 files change
>-Original Message-
>From: Tom Rini [mailto:tr...@konsulko.com]
>Sent: Tuesday, May 02, 2017 8:24 PM
>To: B, Ravi
>Cc: u-boot@lists.denx.de
>Subject: Re: [U-Boot] [PATCH v2 2/3] common: dfu: ignore reset for spl-dfu
>On Tue, May 02, 2017 at 01:56:45PM +,
On Tue, May 02, 2017 at 01:56:45PM +, B, Ravi wrote:
> Tom
>
> >>Can you give the exact bytes saved in each case, with your specific
> >>compiler? I ask since I'm surprised it's more than a function being
> >>dropped by the linker in this case. diff'ing the u-boot-spl.map files
> >>would
Tom
>>Can you give the exact bytes saved in each case, with your specific compiler?
>> I ask since I'm surprised it's more than a function being dropped by the
>>linker in this case. diff'ing the u-boot-spl.map files would also say what
>>is dropped and I'd be interested in that. > (And >yes,
Tom
>> >> >I don't just mean dropping out CLI, I mean after dropping out CLI but
>> >> >leaving in the reset logic. That's _still_ 7k?
>> >>
>> >> Without this fix, with cli_simple_run_command(), size of MLO with default
>> >> dra7xx_evm_defconfig is 130K.
>> >> With this fix, compile out cli.
On Tue, May 02, 2017 at 01:02:24PM +, B, Ravi wrote:
> Tom
>
> >> >>
> >> >> I observed around 7K reduced.
> >>
> >> >I don't just mean dropping out CLI, I mean after dropping out CLI but
> >> >leaving in the reset logic. That's _still_ 7k?
> >>
> >> Without this fix, with cli_simple_run
Tom
>> >>
>> >> I observed around 7K reduced.
>>
>> >I don't just mean dropping out CLI, I mean after dropping out CLI but
>> >leaving in the reset logic. That's _still_ 7k?
>>
>> Without this fix, with cli_simple_run_command(), size of MLO with default
>> dra7xx_evm_defconfig is 130K.
>> W
On Tue, May 02, 2017 at 12:41:48PM +, B, Ravi wrote:
> Tom
>
> >> >>
> >> >> static int dfu_find_alt_num(const char *s)
> >>
> >> >So do we still need the above, in order to save space? How much are we
> >> >saving here even, now? Thanks!
> >>
> >> I observed around 7K reduced.
>
> >
>Tom
>>> >>
>>> >> static int dfu_find_alt_num(const char *s)
>>>
>>> >So do we still need the above, in order to save space? How much are we
>>> >saving here even, now? Thanks!
>>>
>>> I observed around 7K reduced.
Ignore 7K figure provided, that's wrong calculation.
>I don't just mean
Tom
>> >>
>> >> static int dfu_find_alt_num(const char *s)
>>
>> >So do we still need the above, in order to save space? How much are we
>> >saving here even, now? Thanks!
>>
>> I observed around 7K reduced.
>I don't just mean dropping out CLI, I mean after dropping out CLI but leaving
On Thu, Apr 27, 2017 at 05:24:09PM +, B, Ravi wrote:
> Hi Tom
>
> >>
> >> diff --git a/common/dfu.c b/common/dfu.c index 0e9f5f5..546a1ab 100644
> >> --- a/common/dfu.c
> >> +++ b/common/dfu.c
> >> @@ -88,7 +88,7 @@ exit:
> >>board_usb_cleanup(usbctrl_index, USB_INIT_DEVICE);
> >>
> >>
Hi Tom
>>
>> diff --git a/common/dfu.c b/common/dfu.c index 0e9f5f5..546a1ab 100644
>> --- a/common/dfu.c
>> +++ b/common/dfu.c
>> @@ -88,7 +88,7 @@ exit:
>> board_usb_cleanup(usbctrl_index, USB_INIT_DEVICE);
>>
>> if (dfu_reset)
>> -run_command("reset", 0);
>> +
On Thu, Apr 27, 2017 at 05:45:20PM +0530, Ravi Babu wrote:
> The SPL-DFU feature enable to load and
> execute u-boot over usb from PC using
> dfu-util.
> Hence dfu-reset should not be issued
> when dfu-util -R switch is issued.
>
> Signed-off-by: Ravi Babu
> ---
> common/dfu.c | 2 +-
> co
The SPL-DFU feature enable to load and
execute u-boot over usb from PC using
dfu-util.
Hence dfu-reset should not be issued
when dfu-util -R switch is issued.
Signed-off-by: Ravi Babu
---
common/dfu.c | 2 +-
common/spl/Kconfig | 4
drivers/dfu/dfu.c | 4
3 files changed, 9 inse
14 matches
Mail list logo
