Re: [U-Boot] [PATCH v2 11/58] keymile: Unroll km/km83xx-common.h

2018-11-26 Thread Holger Brunck
Hi Mario, >> On Tue, Nov 13, 2018 at 11:42 AM Holger Brunck >> wrote: >> >> could you elaborate why you need to do this? Turning 320 lines into 2579 >> does not sound like simplifying the code.  I understand that you >> try to move a lot of config options to Kconfig for 83xx, which is good. But

Re: [U-Boot] [PATCH v2 11/58] keymile: Unroll km/km83xx-common.h

2018-11-25 Thread Mario Six
Hi Holger, On Tue, Nov 13, 2018 at 11:42 AM Holger Brunck wrote: > > Hi Mario, > > > Simplify the keymile config files once more by unrolling the > > km/km83xx-common.h, and resolve the #ifdef logic as needed. > > > > Signed-off-by: Mario Six > > > > --- > > > > v1 -> v2: > > No changes > > > >

Re: [U-Boot] [PATCH v2 11/58] keymile: Unroll km/km83xx-common.h

2018-11-13 Thread Holger Brunck
Hi Mario, > Simplify the keymile config files once more by unrolling the > km/km83xx-common.h, and resolve the #ifdef logic as needed. > > Signed-off-by: Mario Six > > --- > > v1 -> v2: > No changes > > ---  > include/configs/km8360.h    | 291 ++-  > in

[U-Boot] [PATCH v2 11/58] keymile: Unroll km/km83xx-common.h

2018-11-05 Thread Mario Six
Simplify the keymile config files once more by unrolling the km/km83xx-common.h, and resolve the #ifdef logic as needed. Signed-off-by: Mario Six --- v1 -> v2: No changes --- include/configs/km8360.h| 291 ++- include/configs/km83xx-common.h | 296 -