Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Anup Patel
On Tue, Feb 5, 2019 at 8:30 PM Andreas Schwab wrote: > > On Feb 05 2019, Anup Patel wrote: > > > Ahh, looks like it is not picking up "CC" set by Makefile. This might > > be because you have removed "-R" from MAKEFLAGS. > > Nope. That fixed it. Cool, I had already approved your PR on OpenSBI Gi

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Andreas Schwab
On Feb 05 2019, Anup Patel wrote: > Ahh, looks like it is not picking up "CC" set by Makefile. This might > be because you have removed "-R" from MAKEFLAGS. Nope. That fixed it. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Anup Patel
On Tue, Feb 5, 2019 at 8:09 PM Andreas Schwab wrote: > > mkdir -p `dirname > /net/hawking/daten/src/riscv/opensbi/build/platform/sifive/fu540/firmware/fw_payload.dep`; > echo " AS-DEPplatform/sifive/fu540/firmware/fw_payload.dep"; echo -n > `dirname > /net/hawking/daten/src/riscv/opensbi/b

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Andreas Schwab
mkdir -p `dirname /net/hawking/daten/src/riscv/opensbi/build/platform/sifive/fu540/firmware/fw_payload.dep`; echo " AS-DEPplatform/sifive/fu540/firmware/fw_payload.dep"; echo -n `dirname /net/hawking/daten/src/riscv/opensbi/build/platform/sifive/fu540/firmware/fw_payload.dep`/ > /net/hawk

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Anup Patel
On Tue, Feb 5, 2019 at 7:10 PM Andreas Schwab wrote: > > On Feb 05 2019, Anup Patel wrote: > > > Okay, if you are doing native compilation then > > make sure CROSS_COMPILE is not set so that > > makefile will take native compiler instead of > > cross-compiler. > > AS-DEPplatform/sifive/fu540

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Andreas Schwab
On Feb 05 2019, Anup Patel wrote: > Okay, if you are doing native compilation then > make sure CROSS_COMPILE is not set so that > makefile will take native compiler instead of > cross-compiler. AS-DEPplatform/sifive/fu540/firmware/fw_payload.dep /bin/sh: -g: command not found Andreas. --

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Anup Patel
On Tue, Feb 5, 2019 at 6:21 PM Andreas Schwab wrote: > > On Feb 05 2019, Anup Patel wrote: > > > The OpenSBI build is similar to Linux and U-Boot. We expect > > CROSS_COMPILE environment variable to be set. > > Why? That doesn't make sense. Use of CROSS_COMPILE environment variable is pretty co

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Andreas Schwab
On Feb 05 2019, Anup Patel wrote: > The OpenSBI build is similar to Linux and U-Boot. We expect > CROSS_COMPILE environment variable to be set. Why? That doesn't make sense. > Example, if you cross-compiler I don't have a cross compiler. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.d

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-05 Thread Anup Patel
On Mon, Feb 4, 2019 at 6:40 PM Andreas Schwab wrote: > > On Feb 04 2019, Atish Patra wrote: > > > Probably your cross compilation is not set. Can you try this ? > > > > export ARCH=riscv > > export CROSS_COMPILE= > > There is no cross compile prefix. > The OpenSBI build is similar to Linux and

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-04 Thread Andreas Schwab
On Feb 04 2019, Atish Patra wrote: > Probably your cross compilation is not set. Can you try this ? > > export ARCH=riscv > export CROSS_COMPILE= There is no cross compile prefix. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-04 Thread Atish Patra
Probably your cross compilation is not set. Can you try this ? export ARCH=riscv export CROSS_COMPILE= Sent from my iPhone > On Feb 4, 2019, at 11:17 AM, Andreas Schwab wrote: > >> On Feb 03 2019, Anup Patel wrote: >> >> Can try with https://github.com/riscv/opensbi.git ? > > AS-DEPpla

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-04 Thread Andreas Schwab
On Feb 03 2019, Anup Patel wrote: > Can try with https://github.com/riscv/opensbi.git ? AS-DEPplatform/sifive/fu540/firmware/fw_payload.dep /bin/sh: -g: command not found Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-02-02 Thread Anup Patel
On Thu, Jan 24, 2019 at 7:27 PM Andreas Schwab wrote: > > On Jan 24 2019, Alexander Graf wrote: > > > On 24.01.19 14:38, Andreas Schwab wrote: > >> On Jan 24 2019, Alexander Graf wrote: > >> > >>> Board_init() is too late. This needs to go into early_board_init_f(). > >> > >> I don't think we ca

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Andreas Schwab
On Jan 24 2019, Alexander Graf wrote: > On 24.01.19 14:38, Andreas Schwab wrote: >> On Jan 24 2019, Alexander Graf wrote: >> >>> Board_init() is too late. This needs to go into early_board_init_f(). >> >> I don't think we can modify the DT that early. > > I'm sure we can. Worst case we have to

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Alexander Graf
On 24.01.19 14:38, Andreas Schwab wrote: > On Jan 24 2019, Alexander Graf wrote: > >> Board_init() is too late. This needs to go into early_board_init_f(). > > I don't think we can modify the DT that early. I'm sure we can. Worst case we have to copy it over to RAM first. What obstacle exact

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Andreas Schwab
On Jan 24 2019, Alexander Graf wrote: > Board_init() is too late. This needs to go into early_board_init_f(). I don't think we can modify the DT that early. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Anup Patel
; Joe Hershberger ; U-Boot Mailing List >>>> b...@lists.denx.de>; Palmer Dabbelt ; Alexander Graf > >>>> ; Christoph Hellwig ; Paul Walmsley > >>>> > >>>> Subject: Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board > >>&g

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Alexander Graf
suse.de] >>>> Sent: Thursday, January 24, 2019 3:24 PM >>>> To: Atish Patra >>>> Cc: Anup Patel ; Anup Patel ; >>>> Joe Hershberger ; U-Boot Mailing List >>> b...@lists.denx.de>; Palmer Dabbelt ; Alexander Graf >>>> ; Christoph H

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Anup Patel
; >> To: Atish Patra > >> Cc: Anup Patel ; Anup Patel ; > >> Joe Hershberger ; U-Boot Mailing List >> b...@lists.denx.de>; Palmer Dabbelt ; Alexander Graf > >> ; Christoph Hellwig ; Paul Walmsley > >> > >> Subject: Re: [U-Boot] [PATCH v2 11/1

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Alexander Graf
List > b...@lists.denx.de>; Palmer Dabbelt ; Alexander Graf >> ; Christoph Hellwig ; Paul Walmsley >> >> Subject: Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support >> >> On Jan 23 2019, Atish Patra wrote: >> >>> or you can try

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Anup Patel
Christoph Hellwig ; Paul Walmsley > > Subject: Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support > > On Jan 23 2019, Atish Patra wrote: > > > or you can try to edit the DT directly and update the FSBL if you are > > comfortable with it. > > I th

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-24 Thread Andreas Schwab
On Jan 23 2019, Atish Patra wrote: > or you can try to edit the DT directly and update the FSBL if you are > comfortable with it. I think it would make sense to add the node in the board init function. That way it would work whether or not the FSBL is updated. Andreas. -- Andreas Schwab, SUSE

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-23 Thread Atish Patra
On 1/22/19 1:30 AM, Andreas Schwab wrote: On Jan 21 2019, Anup Patel wrote: On Mon, Jan 21, 2019 at 10:40 PM Andreas Schwab wrote: On Jan 21 2019, Anup Patel wrote: There is a fix required in BBL for real board. We have not send this fix to riscv-pk. Just to clarify, we hacked U-boot

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-22 Thread Andreas Schwab
On Jan 21 2019, Anup Patel wrote: > On Mon, Jan 21, 2019 at 10:40 PM Andreas Schwab wrote: >> >> On Jan 21 2019, Anup Patel wrote: >> >> > There is a fix required in BBL for real board. We have not send >> > this fix to riscv-pk. >> >> Where can I find the patch? > > The fix is to set following

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Bin Meng
On Fri, Jan 18, 2019 at 7:19 PM Anup Patel wrote: > > This patch adds SiFive FU540 board support. For now, only > SiFive serial, SiFive PRCI, and Cadance MACB drivers are > only enabled. The SiFive FU540 defconfig by default builds > U-Boot for S-Mode because U-Boot on SiFive FU540 will run > in S

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Anup Patel
On Mon, Jan 21, 2019 at 10:40 PM Andreas Schwab wrote: > > On Jan 21 2019, Anup Patel wrote: > > > There is a fix required in BBL for real board. We have not send > > this fix to riscv-pk. > > Where can I find the patch? The fix is to set following DT prop in /chosen DT node: stdout-path = "/soc

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Andreas Schwab
On Jan 21 2019, Anup Patel wrote: > There is a fix required in BBL for real board. We have not send > this fix to riscv-pk. Where can I find the patch? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for s

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Anup Patel
On Mon, Jan 21, 2019 at 10:06 PM Andreas Schwab wrote: > > On Jan 21 2019, Anup Patel wrote: > > > On real board, we generally boot OpenSBI+U-Boot. We will > > try and share log of BBL+U-Boot on real board but the log will > > look exactly like above. > > Nothing is seen on the real board. There

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Andreas Schwab
On Jan 21 2019, Anup Patel wrote: > On real board, we generally boot OpenSBI+U-Boot. We will > try and share log of BBL+U-Boot on real board but the log will > look exactly like above. Nothing is seen on the real board. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Anup Patel
On Mon, Jan 21, 2019 at 7:26 PM Andreas Schwab wrote: > > On Jan 18 2019, Anup Patel wrote: > > > This patch adds SiFive FU540 board support. For now, only > > SiFive serial, SiFive PRCI, and Cadance MACB drivers are > > only enabled. The SiFive FU540 defconfig by default builds > > U-Boot for S-

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Andreas Schwab
On Jan 18 2019, Anup Patel wrote: > This patch adds SiFive FU540 board support. For now, only > SiFive serial, SiFive PRCI, and Cadance MACB drivers are > only enabled. The SiFive FU540 defconfig by default builds > U-Boot for S-Mode because U-Boot on SiFive FU540 will run > in S-Mode as payload

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-21 Thread Auer, Lukas
On Sun, 2019-01-20 at 17:22 -0800, Atish Patra wrote: > On 1/20/19 12:26 PM, Auer, Lukas wrote: > > Hi Anup, > > > > On Fri, 2019-01-18 at 11:19 +, Anup Patel wrote: > > > This patch adds SiFive FU540 board support. For now, only > > > SiFive serial, SiFive PRCI, and Cadance MACB drivers are >

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-20 Thread Atish Patra
On 1/20/19 12:26 PM, Auer, Lukas wrote: Hi Anup, On Fri, 2019-01-18 at 11:19 +, Anup Patel wrote: This patch adds SiFive FU540 board support. For now, only SiFive serial, SiFive PRCI, and Cadance MACB drivers are only enabled. The SiFive FU540 defconfig by default builds U-Boot for S-Mode b

Re: [U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-20 Thread Auer, Lukas
Hi Anup, On Fri, 2019-01-18 at 11:19 +, Anup Patel wrote: > This patch adds SiFive FU540 board support. For now, only > SiFive serial, SiFive PRCI, and Cadance MACB drivers are > only enabled. The SiFive FU540 defconfig by default builds > U-Boot for S-Mode because U-Boot on SiFive FU540 will

[U-Boot] [PATCH v2 11/11] riscv: Add SiFive FU540 board support

2019-01-18 Thread Anup Patel
This patch adds SiFive FU540 board support. For now, only SiFive serial, SiFive PRCI, and Cadance MACB drivers are only enabled. The SiFive FU540 defconfig by default builds U-Boot for S-Mode because U-Boot on SiFive FU540 will run in S-Mode as payload of BBL or OpenSBI. Signed-off-by: Atish Patra