Re: [U-Boot] [PATCH v2 1/8] spi: cadence_qspi: Fix clearing of pol/pha bits

2016-11-25 Thread Phil Edworthy
Hi Jagan, On 25 November 2016 15:29 Jagan Teki wrote: > On Fri, Nov 25, 2016 at 8:08 PM, Phil Edworthy > wrote: > > Or'ing together bit positions is clearly wrong. > > > > Signed-off-by: Phil Edworthy > > --- > > drivers/spi/cadence_qspi_apb.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 de

Re: [U-Boot] [PATCH v2 1/8] spi: cadence_qspi: Fix clearing of pol/pha bits

2016-11-25 Thread Jagan Teki
On Fri, Nov 25, 2016 at 8:08 PM, Phil Edworthy wrote: > Or'ing together bit positions is clearly wrong. > > Signed-off-by: Phil Edworthy > --- > drivers/spi/cadence_qspi_apb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/sp

Re: [U-Boot] [PATCH v2 1/8] spi: cadence_qspi: Fix clearing of pol/pha bits

2016-11-25 Thread Marek Vasut
On 11/25/2016 03:38 PM, Phil Edworthy wrote: > Or'ing together bit positions is clearly wrong. > > Signed-off-by: Phil Edworthy > --- > drivers/spi/cadence_qspi_apb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadenc

[U-Boot] [PATCH v2 1/8] spi: cadence_qspi: Fix clearing of pol/pha bits

2016-11-25 Thread Phil Edworthy
Or'ing together bit positions is clearly wrong. Signed-off-by: Phil Edworthy --- drivers/spi/cadence_qspi_apb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/cadence_qspi_apb.c b/drivers/spi/cadence_qspi_apb.c index e285d3c..2403e71 100644 --- a/drivers/spi/