Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-03 Thread Igor Grinberg
On 02/03/12 14:50, Govindraj wrote: [...] >>> >>> COBJS := $(COBJS-y) >>> SRCS := $(COBJS:.o=.c) >>> diff --git a/drivers/usb/ulpi/omap-ulpi-viewport.c >>> b/drivers/usb/ulpi/omap-ulpi-viewport.c >>> new file mode 100644 >>> index 000..1718788 >>> --- /dev/null >>> +++ b/drivers/usb/ulpi/o

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-03 Thread Govindraj
On Sun, Jan 29, 2012 at 5:12 PM, Stefano Babic wrote: > On 29/01/2012 10:42, Igor Grinberg wrote: >> Hi Govindraj, >> > > Hi all, > >> Put Remy on Cc. > > Remy resigned as USB maintainer - but Tom is aware about these patches... > >> >> Note: my new mail client for some reason, messes with white s

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-03 Thread Govindraj
Hi Igor, Sorry for late reply, Was really busy with some other tasks. On Sun, Jan 29, 2012 at 3:12 PM, Igor Grinberg wrote: > Hi Govindraj, > > Put Remy on Cc. > Yes Sure, > Note: my new mail client for some reason, messes with white spaces... > (Thunderbird (9) just gets better and better...

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-01 Thread Igor Grinberg
On 02/01/12 13:26, Stefano Babic wrote: > On 01/02/2012 12:01, Igor Grinberg wrote: > >> Thanks for testing! >> >> Govidraj, can the "enabling the ULPI for boards" reside >> in a separate patch and also include the boards that were >> tested with it (e.g. TAM3517)? > > Well, this is maybe too muc

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-01 Thread Stefano Babic
On 01/02/2012 12:01, Igor Grinberg wrote: > Thanks for testing! > > Govidraj, can the "enabling the ULPI for boards" reside > in a separate patch and also include the boards that were > tested with it (e.g. TAM3517)? Well, this is maybe too much ;-) ... and Govidraj has no possibility to test i

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-02-01 Thread Igor Grinberg
Hi Stefano, On 01/29/12 13:42, Stefano Babic wrote: > On 29/01/2012 10:42, Igor Grinberg wrote: >> Hi Govindraj, >> > > Hi all, > >> Put Remy on Cc. > > Remy resigned as USB maintainer - but Tom is aware about these patches... Right. This patch touches the USB subsystem, therefore I put Remy i

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-29 Thread Stefano Babic
On 29/01/2012 10:42, Igor Grinberg wrote: > Hi Govindraj, > Hi all, > Put Remy on Cc. Remy resigned as USB maintainer - but Tom is aware about these patches... > > Note: my new mail client for some reason, messes with white spaces... > (Thunderbird (9) just gets better and better...) I had t

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-29 Thread Igor Grinberg
Hi Govindraj, Put Remy on Cc. Note: my new mail client for some reason, messes with white spaces... (Thunderbird (9) just gets better and better...) So, please ignore those. BTW, is there anyone who has those issues fixed and can save me a wasted hour? On 01/27/12 15:29, Govindraj wrote: On We

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-27 Thread Govindraj
On Wed, Jan 25, 2012 at 7:10 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 01/25/12 11:04, Govindraj wrote: >> Hi Igor, >> >> On Sun, Jan 22, 2012 at 5:50 PM, Igor Grinberg >> wrote: >>> On 01/19/12 10:15, Govindraj wrote: On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg wrote:

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-25 Thread Igor Grinberg
Hi Govindraj, On 01/25/12 11:04, Govindraj wrote: > Hi Igor, > > On Sun, Jan 22, 2012 at 5:50 PM, Igor Grinberg > wrote: >> On 01/19/12 10:15, Govindraj wrote: >>> On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg >>> wrote: Hi Govindraj, On 01/17/12 08:10, Govindraj wrote: >

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-25 Thread Govindraj
Hi Igor, On Sun, Jan 22, 2012 at 5:50 PM, Igor Grinberg wrote: > On 01/19/12 10:15, Govindraj wrote: >> On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg >> wrote: >>> Hi Govindraj, >>> >>> On 01/17/12 08:10, Govindraj wrote: [...] +             if (get_timer(init) > CONFIG_SYS_HZ) {

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-22 Thread Igor Grinberg
On 01/19/12 10:15, Govindraj wrote: > On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg > wrote: >> Hi Govindraj, >> >> On 01/17/12 08:10, Govindraj wrote: >>> >>> And just to clarify further there is no code duplication for ulpi read >>> writes >>> in ehci-omap.c done with this patch. >> >> This

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-19 Thread Govindraj
On Wed, Jan 18, 2012 at 11:21 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 01/17/12 08:10, Govindraj wrote: >> >> And just to clarify further there is no code duplication for ulpi read writes >> in ehci-omap.c done with this patch. > > This is not just about code duplication, > this is also abo

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-18 Thread Igor Grinberg
Hi Govindraj, On 01/17/12 08:10, Govindraj wrote: > > And just to clarify further there is no code duplication for ulpi read writes > in ehci-omap.c done with this patch. This is not just about code duplication, this is also about using the ULPI framework instead of direct writes to the ULPI PHY

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-17 Thread Igor Grinberg
Hi Govindraj, I'm sorry it took me so much time, I just was very busy these days... I've looked in the TRMs of both OMAP3 and OMAP4, please see below. On 01/12/12 12:52, Govindraj wrote: > On Thu, Jan 12, 2012 at 2:53 PM, Igor Grinberg > wrote: >> Hi Govindraj, >> >> On 01/12/12 07:45, Govindra

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-16 Thread Govindraj
On Thu, Jan 12, 2012 at 4:22 PM, Govindraj wrote: > On Thu, Jan 12, 2012 at 2:53 PM, Igor Grinberg > wrote: >> Hi Govindraj, >> >> On 01/12/12 07:45, Govindraj wrote: >>> Hi Igor, >>> >>> On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg >>> wrote: Hi Guys, On 01/11/12 16:34, Marek

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-12 Thread Govindraj
On Thu, Jan 12, 2012 at 2:53 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 01/12/12 07:45, Govindraj wrote: >> Hi Igor, >> >> On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg >> wrote: >>> Hi Guys, >>> >>> On 01/11/12 16:34, Marek Vasut wrote: > On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-12 Thread Igor Grinberg
Hi Govindraj, On 01/12/12 07:45, Govindraj wrote: > Hi Igor, > > On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg > wrote: >> Hi Guys, >> >> On 01/11/12 16:34, Marek Vasut wrote: On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut >>

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
Hi Igor, On Wed, Jan 11, 2012 at 8:33 PM, Igor Grinberg wrote: > Hi Guys, > > On 01/11/12 16:34, Marek Vasut wrote: >>> On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: > On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut > wrote: >>> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut >> w

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Marek Vasut
> Hi Guys, > > On 01/11/12 16:34, Marek Vasut wrote: > >> On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: > On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: > >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut > > > > wrote: > Hi Marek, > > Thanks for

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Igor Grinberg
Hi Guys, On 01/11/12 16:34, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut > wrote: Hi Marek, Thanks for you review. >

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Marek Vasut
> On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: > >> On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: > >> >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: > >> >> >> Hi Marek, > >> >> >> > >> >> >> Thanks for you review. > >> >> >> > >> >> >> On Tue, Jan 10, 2012 at 9:37 PM, M

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 6:58 PM, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: >> >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut >> >> wrote: >> >> >> Hi Marek, >> >> >> >> >> >> Thanks for you review. >> >> >> >> >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Marek Vasut
> On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: > >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: > >> >> Hi Marek, > >> >> > >> >> Thanks for you review. > >> >> > >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: > >> >> >> From: "Govindraj.R" > >> >> >> > >> >> >> Cl

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 6:16 PM, Marek Vasut wrote: >> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: >> >> Hi Marek, >> >> >> >> Thanks for you review. >> >> >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut >> >> wrote: >> >> >> From: "Govindraj.R" >> >> >> >> >> >> Clean up added ehci

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Marek Vasut
> On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: > >> Hi Marek, > >> > >> Thanks for you review. > >> > >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: > >> >> From: "Govindraj.R" > >> >> > >> >> Clean up added ehci-omap.c and make it generic for re-use across > >> >> soc having s

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 4:22 PM, Marek Vasut wrote: >> Hi Marek, >> >> Thanks for you review. >> >> On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: >> >> From: "Govindraj.R" >> >> >> >> Clean up added ehci-omap.c and make it generic for re-use across >> >> soc having same ehci ip block. Also

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-11 Thread Marek Vasut
> Hi Marek, > > Thanks for you review. > > On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: > >> From: "Govindraj.R" > >> > >> Clean up added ehci-omap.c and make it generic for re-use across > >> soc having same ehci ip block. Also pass the modes to be configured > >> and configure the por

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-10 Thread Govindraj
Hi Marek, Thanks for you review. On Tue, Jan 10, 2012 at 9:37 PM, Marek Vasut wrote: >> From: "Govindraj.R" >> >> Clean up added ehci-omap.c and make it generic for re-use across >> soc having same ehci ip block. Also pass the modes to be configured >> and configure the ports accordingly. All u

Re: [U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-10 Thread Marek Vasut
> From: "Govindraj.R" > > Clean up added ehci-omap.c and make it generic for re-use across > soc having same ehci ip block. Also pass the modes to be configured > and configure the ports accordingly. All usb layers are not cache > aligned till then keep cache off for usb ops as ehci will use > in

[U-Boot] [PATCH v2 1/4] ehci-omap: Clean up added ehci-omap.c

2012-01-06 Thread Govindraj.R
From: "Govindraj.R" Clean up added ehci-omap.c and make it generic for re-use across soc having same ehci ip block. Also pass the modes to be configured and configure the ports accordingly. All usb layers are not cache aligned till then keep cache off for usb ops as ehci will use internally dma f