Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-24 Thread Stephen Warren
On 10/24/2012 02:17 PM, Marek Vasut wrote: > Dear Allen Martin, > > [...] > >>> [...] >>> >>> Good, now please fix the bug. I'm terribly unhappy seeing there is a bug >>> that is about to go unfixed. >> >> I didn't say the bug will go unfixed, I've opened an issue in our >> internal bug tracker s

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-24 Thread Marek Vasut
Dear Allen Martin, [...] > > [...] > > > > Good, now please fix the bug. I'm terribly unhappy seeing there is a bug > > that is about to go unfixed. > > I didn't say the bug will go unfixed, I've opened an issue in our > internal bug tracker so it doesn't go forgotten. It's just a matter > of

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-24 Thread Allen Martin
On Wed, Oct 24, 2012 at 12:31:40AM -0700, Marek Vasut wrote: > Dear Allen Martin, > > > On Tue, Oct 23, 2012 at 03:03:34PM -0700, Marek Vasut wrote: > > > Dear Allen Martin, > > > > > > > On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote: > > > > > On 10/22/2012 11:47 PM, Allen Marti

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-24 Thread Marek Vasut
Dear Allen Martin, > On Tue, Oct 23, 2012 at 03:03:34PM -0700, Marek Vasut wrote: > > Dear Allen Martin, > > > > > On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote: > > > > On 10/22/2012 11:47 PM, Allen Martin wrote: > > > > > Change usb_kbd driver to obey alignment requirements for

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Allen Martin
On Tue, Oct 23, 2012 at 05:39:50PM -0700, Allen Martin wrote: > On Tue, Oct 23, 2012 at 03:03:34PM -0700, Marek Vasut wrote: > > Dear Allen Martin, > > > > > On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote: > > > > On 10/22/2012 11:47 PM, Allen Martin wrote: > > > > > Change usb_kbd

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Allen Martin
On Tue, Oct 23, 2012 at 03:03:34PM -0700, Marek Vasut wrote: > Dear Allen Martin, > > > On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote: > > > On 10/22/2012 11:47 PM, Allen Martin wrote: > > > > Change usb_kbd driver to obey alignment requirements for USB DMA on > > > > the buffer u

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Marek Vasut
Dear Allen Martin, > On Tue, Oct 23, 2012 at 12:26:31AM -0700, Marek Vasut wrote: > > Dear Allen Martin, > > > > > Change usb_kbd driver to obey alignment requirements for USB DMA on > > > the buffer used for data transfer. This is necessary for > > > architectures that enable dcache and enable

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Marek Vasut
Dear Allen Martin, > On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote: > > On 10/22/2012 11:47 PM, Allen Martin wrote: > > > Change usb_kbd driver to obey alignment requirements for USB DMA on > > > the buffer used for data transfer. This is necessary for > > > architectures that en

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Allen Martin
On Tue, Oct 23, 2012 at 09:51:06AM -0700, Stephen Warren wrote: > On 10/22/2012 11:47 PM, Allen Martin wrote: > > Change usb_kbd driver to obey alignment requirements for USB DMA on > > the buffer used for data transfer. This is necessary for > > architectures that enable dcache and enable USB DMA

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Allen Martin
On Tue, Oct 23, 2012 at 12:26:31AM -0700, Marek Vasut wrote: > Dear Allen Martin, > > > Change usb_kbd driver to obey alignment requirements for USB DMA on > > the buffer used for data transfer. This is necessary for > > architectures that enable dcache and enable USB DMA. > > > > Signed-off-by:

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Stephen Warren
On 10/22/2012 11:47 PM, Allen Martin wrote: > Change usb_kbd driver to obey alignment requirements for USB DMA on > the buffer used for data transfer. This is necessary for > architectures that enable dcache and enable USB DMA. The series, Tested-by: Stephen Warren BTW, I tested tegra-kbc too,

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Stephen Warren
On 10/23/2012 01:26 AM, Marek Vasut wrote: > Dear Allen Martin, > >> Change usb_kbd driver to obey alignment requirements for USB DMA on >> the buffer used for data transfer. This is necessary for >> architectures that enable dcache and enable USB DMA. >> @@ -426,7 +426,7 @@ static int usb_kbd_p

Re: [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-23 Thread Marek Vasut
Dear Allen Martin, > Change usb_kbd driver to obey alignment requirements for USB DMA on > the buffer used for data transfer. This is necessary for > architectures that enable dcache and enable USB DMA. > > Signed-off-by: Allen Martin > --- > common/usb_kbd.c |8 > 1 file changed,

[U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements

2012-10-22 Thread Allen Martin
Change usb_kbd driver to obey alignment requirements for USB DMA on the buffer used for data transfer. This is necessary for architectures that enable dcache and enable USB DMA. Signed-off-by: Allen Martin --- common/usb_kbd.c |8 1 file changed, 4 insertions(+), 4 deletions(-) di