Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-09 Thread Simon Glass
On 9 September 2015 at 12:05, Simon Glass wrote: > Hi Joe, > > On 8 September 2015 at 09:09, Joe Hershberger > wrote: >> Hi Simon, >> >> On Tue, Sep 8, 2015 at 9:22 AM, Simon Glass wrote: >>> Hi Joe, >>> >>> On 4 September 2015 at 23:57, Bin Meng wrote: Hi Joe, On Fri, Sep 4, 20

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-09 Thread Simon Glass
Hi Joe, On 8 September 2015 at 09:09, Joe Hershberger wrote: > Hi Simon, > > On Tue, Sep 8, 2015 at 9:22 AM, Simon Glass wrote: >> Hi Joe, >> >> On 4 September 2015 at 23:57, Bin Meng wrote: >>> Hi Joe, >>> >>> On Fri, Sep 4, 2015 at 11:29 PM, Joe Hershberger >>> wrote: Hi Bin,

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-08 Thread Joe Hershberger
Hi Simon, On Tue, Sep 8, 2015 at 9:22 AM, Simon Glass wrote: > Hi Joe, > > On 4 September 2015 at 23:57, Bin Meng wrote: >> Hi Joe, >> >> On Fri, Sep 4, 2015 at 11:29 PM, Joe Hershberger >> wrote: >>> Hi Bin, >>> >>> On Wed, Sep 2, 2015 at 4:17 AM, Bin Meng wrote: The Designware ethernet

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-08 Thread Simon Glass
Hi Joe, On 4 September 2015 at 23:57, Bin Meng wrote: > Hi Joe, > > On Fri, Sep 4, 2015 at 11:29 PM, Joe Hershberger > wrote: >> Hi Bin, >> >> On Wed, Sep 2, 2015 at 4:17 AM, Bin Meng wrote: >>> The Designware ethernet controller is also seen on PCI bus, e.g. >>> on Intel Quark SoC. Add this su

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-04 Thread Bin Meng
Hi Joe, On Fri, Sep 4, 2015 at 11:29 PM, Joe Hershberger wrote: > Hi Bin, > > On Wed, Sep 2, 2015 at 4:17 AM, Bin Meng wrote: >> The Designware ethernet controller is also seen on PCI bus, e.g. >> on Intel Quark SoC. Add this support in the DM version driver. >> >> Signed-off-by: Bin Meng > > L

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-04 Thread Joe Hershberger
Hi Bin, On Wed, Sep 2, 2015 at 4:17 AM, Bin Meng wrote: > The Designware ethernet controller is also seen on PCI bus, e.g. > on Intel Quark SoC. Add this support in the DM version driver. > > Signed-off-by: Bin Meng Looks good. One question below. > --- > > Changes in v2: > - Change to use dev

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-02 Thread Bin Meng
Hi Simon, On Wed, Sep 2, 2015 at 10:05 PM, Simon Glass wrote: > Hi Bin, > > On 2 September 2015 at 03:17, Bin Meng wrote: >> The Designware ethernet controller is also seen on PCI bus, e.g. >> on Intel Quark SoC. Add this support in the DM version driver. >> >> Signed-off-by: Bin Meng >> >> ---

Re: [U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-02 Thread Simon Glass
Hi Bin, On 2 September 2015 at 03:17, Bin Meng wrote: > The Designware ethernet controller is also seen on PCI bus, e.g. > on Intel Quark SoC. Add this support in the DM version driver. > > Signed-off-by: Bin Meng > > --- > > Changes in v2: > - Change to use device_is_on_pci_bus() > > drivers/n

[U-Boot] [PATCH v2 09/11] net: designware: Add support to PCI designware devices

2015-09-02 Thread Bin Meng
The Designware ethernet controller is also seen on PCI bus, e.g. on Intel Quark SoC. Add this support in the DM version driver. Signed-off-by: Bin Meng --- Changes in v2: - Change to use device_is_on_pci_bus() drivers/net/designware.c | 39 +++ 1 file chang