Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 11:34, José Miguel Gonçalves wrote: > On 17-09-2012 19:27, Tom Rini wrote: >> On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves >> wrote: >>> On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: S

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 19:27, Tom Rini wrote: On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves wrote: On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, Jos? Miguel Gon?alves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16,

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
On Mon, Sep 17, 2012 at 07:05:48PM +0100, Jos? Miguel Gon?alves wrote: > On 17-09-2012 18:56, Tom Rini wrote: > >-BEGIN PGP SIGNED MESSAGE- > >Hash: SHA1 > > > >On 09/17/12 10:08, Jos? Miguel Gon?alves wrote: > >>On 17-09-2012 17:57, Tom Rini wrote: > >>>On Sun, Sep 16, 2012 at 10:16:47AM +

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 18:56, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, José Miguel Gonçalves wrote: On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 1

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/17/12 10:08, José Miguel Gonçalves wrote: > On 17-09-2012 17:57, Tom Rini wrote: >> On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves >> wrote: >>> On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +010

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Scott Wood
On 09/17/2012 12:08:17 PM, Tom Rini wrote: On 09/17/12 10:03, Scott Wood wrote: > Weak symbols are not OK for configuring printf out of the SPL, as you'll > still have all the format strings and caller code in the binary. It > should be a macro (or an inline function that replaces the standar

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
On 09/17/12 10:03, Scott Wood wrote: > On 09/17/2012 11:57:57 AM, Tom Rini wrote: >> On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: >> > On 09/14/2012 08:01 PM, Tom Rini wrote: >> > >On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: >> > >>On 14-09-2012

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
On 17-09-2012 17:57, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Scott Wood
On 09/17/2012 11:57:57 AM, Tom Rini wrote: On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: > On 09/14/2012 08:01 PM, Tom Rini wrote: > >On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: > >>On 14-09-2012 19:21, Marek Vasut wrote: > >>>Dear Jos? Migue

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread Tom Rini
On Sun, Sep 16, 2012 at 10:16:47AM +0100, Jos? Miguel Gon?alves wrote: > On 09/14/2012 08:01 PM, Tom Rini wrote: > >On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: > >>On 14-09-2012 19:21, Marek Vasut wrote: > >>>Dear Jos? Miguel Gon?alves, > >>> > NAND Flash driver with

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-17 Thread José Miguel Gonçalves
Hi Marek, On 14-09-2012 19:21, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves [...] +#include +#include +#include +#include +#include + +#define MAX_CHI

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-16 Thread José Miguel Gonçalves
On 09/14/2012 08:01 PM, Tom Rini wrote: On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: On 14-09-2012 19:21, Marek Vasut wrote: Dear Jos? Miguel Gon?alves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: Jos

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Scott Wood
On Fri, Sep 14, 2012 at 01:20:32PM -0700, Tom Rini wrote: > On Fri, Sep 14, 2012 at 02:24:48PM -0500, Scott Wood wrote: > > On Fri, Sep 14, 2012 at 08:21:11PM +0200, Marek Vasut wrote: > > > Dear Jos? Miguel Gon?alves, > > > > > > > NAND Flash driver with HW ECC for the S3C24XX SoCs. > > > > Curre

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 02:24:48PM -0500, Scott Wood wrote: > On Fri, Sep 14, 2012 at 08:21:11PM +0200, Marek Vasut wrote: > > Dear Jos? Miguel Gon?alves, > > > > > NAND Flash driver with HW ECC for the S3C24XX SoCs. > > > Currently it only supports SLC NAND chips. > > > > > > Signed-off-by: Jos?

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Scott Wood
On Fri, Sep 14, 2012 at 08:21:11PM +0200, Marek Vasut wrote: > Dear José Miguel Gonçalves, > > > NAND Flash driver with HW ECC for the S3C24XX SoCs. > > Currently it only supports SLC NAND chips. > > > > Signed-off-by: José Miguel Gonçalves > > [...] > > > +#include > > +#include > > +#inclu

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 07:45:40PM +0100, Jos? Miguel Gon?alves wrote: > On 14-09-2012 19:21, Marek Vasut wrote: > >Dear Jos? Miguel Gon?alves, > > > >>NAND Flash driver with HW ECC for the S3C24XX SoCs. > >>Currently it only supports SLC NAND chips. > >> > >>Signed-off-by: Jos? Miguel Gon?alves >

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Tom Rini
On Fri, Sep 14, 2012 at 06:29:00PM +0100, Jos?? Miguel Gon??alves wrote: > NAND Flash driver with HW ECC for the S3C24XX SoCs. > Currently it only supports SLC NAND chips. > > Signed-off-by: Jos?? Miguel Gon??alves [snip] > +#ifdef CONFIG_SPL_BUILD > +#define printf(arg...) do {} while (0) > +#e

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread José Miguel Gonçalves
On 14-09-2012 19:21, Marek Vasut wrote: Dear José Miguel Gonçalves, NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves [...] +#include +#include +#include +#include +#include + +#define MAX_CHIPS 2 +

Re: [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread Marek Vasut
Dear José Miguel Gonçalves, > NAND Flash driver with HW ECC for the S3C24XX SoCs. > Currently it only supports SLC NAND chips. > > Signed-off-by: José Miguel Gonçalves [...] > +#include > +#include > +#include > +#include > +#include > + > +#define MAX_CHIPS2 > +static int nand_cs[MAX

[U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

2012-09-14 Thread José Miguel Gonçalves
NAND Flash driver with HW ECC for the S3C24XX SoCs. Currently it only supports SLC NAND chips. Signed-off-by: José Miguel Gonçalves --- Changes for v2: - Coding style cleanup - Use of clrsetbits_le32() - Use of register bit macros instead of magic numbers --- drivers/mtd/nand/Makefile