Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-31 Thread Simon Glass
Hi Benjamin, On 29 July 2016 at 12:34, Benjamin Tietz wrote: > Hello Stephen, > > On Fri, Jul 29, 2016 at 12:02:02PM -0600, Stephen Warren wrote: >> On 07/29/2016 11:26 AM, Benjamin Tietz wrote: >> >Hello Stephen, > > [snip] > >> >>>Using a special high number looks unintuitive. And often result

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-29 Thread Benjamin Tietz
Hello Stephen, On Fri, Jul 29, 2016 at 12:02:02PM -0600, Stephen Warren wrote: > On 07/29/2016 11:26 AM, Benjamin Tietz wrote: > >Hello Stephen, [snip] > >>>Using a special high number looks unintuitive. And often result in > >>>additional work-arounds in the future. > >> > >>What specific issue

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-29 Thread Stephen Warren
On 07/29/2016 11:26 AM, Benjamin Tietz wrote: Hello Stephen, On Fri, Jul 29, 2016 at 10:04:56AM -0600, Stephen Warren wrote: On 07/28/2016 01:28 PM, Benjamin Tietz wrote: Hello Vikas, hello Simon, the new clk-API leaves me with a problem. Previously there was a seperate way to access the cloc

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-29 Thread Benjamin Tietz
Hello Stephen, On Fri, Jul 29, 2016 at 10:04:56AM -0600, Stephen Warren wrote: > On 07/28/2016 01:28 PM, Benjamin Tietz wrote: > >Hello Vikas, hello Simon, > > > >the new clk-API leaves me with a problem. Previously there was a > >seperate way to access the clock-device itself (using clk_[gs]et_ra

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-29 Thread Stephen Warren
On 07/28/2016 01:28 PM, Benjamin Tietz wrote: Hello Vikas, hello Simon, the new clk-API leaves me with a problem. Previously there was a seperate way to access the clock-device itself (using clk_[gs]et_rate) and the peripherals connected (clk_[gs]et_periph_rate). The former case now isn't availa

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-28 Thread Benjamin Tietz
Hello Vikas, hello Simon, sleeping a night over this issue, I've came along with the following concept: The peripheral clocks are grouped by peripheral bus, that they are connected to. Each bus is driven by one or more set of registers, allowing up to 32 clocks to be selected. Having more than 8

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-28 Thread Benjamin Tietz
Hello Vikas, hello Simon, the new clk-API leaves me with a problem. Previously there was a seperate way to access the clock-device itself (using clk_[gs]et_rate) and the peripherals connected (clk_[gs]et_periph_rate). The former case now isn't available no more. But the system clock in STM32 doesn

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-28 Thread Benjamin Tietz
Hi Simon, On Tue, Jul 12, 2016 at 10:02:43AM -0600, Simon Glass wrote: > +Stephen > > Hi Benjamin, > > On 20 June 2016 at 12:26, Benjamin Tietz wrote: > > From: Benjamin Tietz > > > > Currently, clocks can be enabled, only. To be feature-complete - and allow > > a bit of power-saving in applic

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-12 Thread Stephen Warren
On 07/12/2016 10:02 AM, Simon Glass wrote: +Stephen Hi Benjamin, On 20 June 2016 at 12:26, Benjamin Tietz wrote: From: Benjamin Tietz Currently, clocks can be enabled, only. To be feature-complete - and allow a bit of power-saving in applications - disabling a clock should be possible, too.

Re: [U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-07-12 Thread Simon Glass
+Stephen Hi Benjamin, On 20 June 2016 at 12:26, Benjamin Tietz wrote: > From: Benjamin Tietz > > Currently, clocks can be enabled, only. To be feature-complete - and allow > a bit of power-saving in applications - disabling a clock should be > possible, too. > > This extend the API of the DM cl

[U-Boot] [PATCH v2 07/22] clock-uclass: allow disabling a peripheral clock

2016-06-20 Thread Benjamin Tietz
From: Benjamin Tietz Currently, clocks can be enabled, only. To be feature-complete - and allow a bit of power-saving in applications - disabling a clock should be possible, too. This extend the API of the DM clock driver to allow a clock to be disabled. The corresponding operation is optional