Re: [U-Boot] [PATCH v2 03/16] efi_loader: add signature verification functions

2019-11-26 Thread AKASHI Takahiro
On Tue, Nov 26, 2019 at 01:55:29PM +0200, Ilias Apalodimas wrote: > [...] > > + /* verify signature */ > > + /* against digest */ > > + c = 0x31; > > + regtmp[0].data = &c; > > + regtmp[0].size = 1; > > Is there a reason for '1' instea of sizeof(c)? Yes,

Re: [U-Boot] [PATCH v2 03/16] efi_loader: add signature verification functions

2019-11-26 Thread Ilias Apalodimas
[...] > + /* verify signature */ > + /* against digest */ > + c = 0x31; > + regtmp[0].data = &c; > + regtmp[0].size = 1; Is there a reason for '1' instea of sizeof(c)? > + regtmp[1].data = ps_info->authattrs; > + regtmp[1

[U-Boot] [PATCH v2 03/16] efi_loader: add signature verification functions

2019-11-25 Thread AKASHI Takahiro
In this commit, implemented are a couple of helper functions which will be used to materialize variable authentication as well as image authentication in later patches. Signed-off-by: AKASHI Takahiro --- include/efi_api.h | 87 + include/efi_loader.h | 72 lib/e