Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Simon Glass
Hi Stephen, On Mon, Dec 5, 2011 at 2:25 PM, Stephen Warren wrote: > On 12/05/2011 03:18 PM, Scott Wood wrote: >> On 12/05/2011 04:11 PM, Simon Glass wrote: >>> Hi Stephen, >>> >>> On Mon, Dec 5, 2011 at 2:07 PM, Stephen Warren wrote: My point is that there are probably .dts files using "ok"

Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Stephen Warren
On 12/05/2011 03:18 PM, Scott Wood wrote: > On 12/05/2011 04:11 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Dec 5, 2011 at 2:07 PM, Stephen Warren wrote: >>> My point is that there are probably .dts files using "ok" instead of >>> "okay" or the kernel wouldn't support "ok". People will pro

Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Scott Wood
On 12/05/2011 04:11 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Dec 5, 2011 at 2:07 PM, Stephen Warren wrote: >> My point is that there are probably .dts files using "ok" instead of >> "okay" or the kernel wouldn't support "ok". People will probably want to >> use those with U-Boot without c

Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Simon Glass
Hi Stephen, On Mon, Dec 5, 2011 at 2:07 PM, Stephen Warren wrote: > On 12/05/2011 02:40 PM, Simon Glass wrote: >> Hi Stephen, >> >> On Mon, Dec 5, 2011 at 1:27 PM, Stephen Warren wrote: >>> On 12/02/2011 07:11 PM, Simon Glass wrote: >>> ... +int fdtdec_get_is_enabled(const void *blob, int n

Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Stephen Warren
On 12/05/2011 02:40 PM, Simon Glass wrote: > Hi Stephen, > > On Mon, Dec 5, 2011 at 1:27 PM, Stephen Warren wrote: >> On 12/02/2011 07:11 PM, Simon Glass wrote: >> ... >>> +int fdtdec_get_is_enabled(const void *blob, int node) >>> { >>> const char *cell; >>> >>> cell = fdt_getprop(bl

Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Simon Glass
Hi Stephen, On Mon, Dec 5, 2011 at 1:27 PM, Stephen Warren wrote: > On 12/02/2011 07:11 PM, Simon Glass wrote: > ... >> +int fdtdec_get_is_enabled(const void *blob, int node) >>  { >>       const char *cell; >> >>       cell = fdt_getprop(blob, node, "status", NULL); >>       if (cell) >> -      

Re: [U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-05 Thread Stephen Warren
On 12/02/2011 07:11 PM, Simon Glass wrote: ... > +int fdtdec_get_is_enabled(const void *blob, int node) > { > const char *cell; > > cell = fdt_getprop(blob, node, "status", NULL); > if (cell) > - return 0 == strcmp(cell, "ok"); > - return default_val; > +

[U-Boot] [PATCH v2 01/17] fdt: Tidy up a few fdtdec problems

2011-12-02 Thread Simon Glass
This fixes five trivial issues in fdtdec.c: 1. fdtdec_get_is_enabled() doesn't really need a default value 2. The fdt must be word-aligned, since otherwise it will fail on ARM 3. The compat_names[] array is missing its first element. This is needed only because the first fdt_compat_id is defined to