Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-18 Thread Stefan Herbrechtsmeier
Am 18.07.2012 14:50, schrieb Marek Vasut: The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in usb_storage as it wrongly assumes that every transfer can use 4096 bytes per qt_buffer. This is wrong if the start address

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-18 Thread Marek Vasut
Dear Stefan Herbrechtsmeier, > The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: > Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in > usb_storage as it wrongly assumes that every transfer can use > 4096 bytes per qt_buffer. This is wrong if the start address of > t

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-15 Thread Ilya Yanok
Dear Marek, On Sun, Jul 15, 2012 at 1:51 PM, Marek Vasut wrote: > > Thanks! I'm marking this important in my mailbox to avoid missing that we > need > to fix this. Ilya, can you check the driver model papers and see if we can > somehow integrate this into that? > > I will try to. Regards, Ilya.

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-15 Thread Marek Vasut
Dear Ilya Yanok, > Dear Marek, > > On Sun, Jul 15, 2012 at 12:14 PM, Marek Vasut wrote: > > > The patch is good in the sense it does fix the real problem. But I > > > wonder if it's a good idea to expose lower layer details (like > > > size/number of buffers per EHCI TD) to upper layer driver? I

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-15 Thread Marek Vasut
Dear Wolfgang Denk, > The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: > Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in > usb_storage as it wrongly assumes that every transfer can use > 4096 bytes per qt_buffer. This is wrong if the start address of > the data i

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-15 Thread Ilya Yanok
Dear Marek, On Sun, Jul 15, 2012 at 12:14 PM, Marek Vasut wrote: > > The patch is good in the sense it does fix the real problem. But I wonder > > if it's a good idea to expose lower layer details (like size/number of > > buffers per EHCI TD) to upper layer driver? I know EHCI is most common > U

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-15 Thread Marek Vasut
Dear Ilya Yanok, > Hi, > > The patch is good in the sense it does fix the real problem. But I wonder > if it's a good idea to expose lower layer details (like size/number of > buffers per EHCI TD) to upper layer driver? I know EHCI is most common USB > HCD but we have drivers for a bunch of other

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-14 Thread Ilya Yanok
Hi, The patch is good in the sense it does fix the real problem. But I wonder if it's a good idea to expose lower layer details (like size/number of buffers per EHCI TD) to upper layer driver? I know EHCI is most common USB HCD but we have drivers for a bunch of others... How about them? Regards,

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-10 Thread Marek Vasut
Dear Stefan Herbrechtsmeier, > The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: > Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in > usb_storage as it wrongly assumes that every transfer can use > 4096 bytes per qt_buffer. This is wrong if the start address of > t

[U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-10 Thread Stefan Herbrechtsmeier
The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in usb_storage as it wrongly assumes that every transfer can use 4096 bytes per qt_buffer. This is wrong if the start address of the data is not page aligned to 4096 byte

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-10 Thread Marek Vasut
Dear Stefan Herbrechtsmeier, > Am 10.07.2012 04:12, schrieb Marek Vasut: > >> The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: > >> Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in > >> usb_storage as it wrongly assumes that every transfer can use > >> 4096 bytes

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-09 Thread Stefan Herbrechtsmeier
Am 10.07.2012 04:12, schrieb Marek Vasut: The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in usb_storage as it wrongly assumes that every transfer can use 4096 bytes per qt_buffer. This is wrong if the start address

Re: [U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-09 Thread Marek Vasut
Dear Stefan Herbrechtsmeier, > The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: > Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in > usb_storage as it wrongly assumes that every transfer can use > 4096 bytes per qt_buffer. This is wrong if the start address of > t

[U-Boot] [PATCH v2] usb_storage: fix ehci driver max transfer size

2012-07-09 Thread Stefan Herbrechtsmeier
The commit 5dd95cf93dfffa1d19a1928990852aac9f55b9d9 'usb_storage: Fix EHCI "out of buffer pointers" with CD-ROM' introduce a bug in usb_storage as it wrongly assumes that every transfer can use 4096 bytes per qt_buffer. This is wrong if the start address of the data is not page aligned to 4096 byte