Re: [U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses

2016-07-11 Thread Ian Campbell
On Mon, 2016-07-11 at 11:02 +0200, Hans de Goede wrote: > > On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote: > > > > > > [...] > > > +static void setup_environment(const void *fdt) > > > > It might be worth adding a commit to this function noting that it > > must > > remain idempotent. >

Re: [U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses

2016-07-11 Thread Hans de Goede
Hi, On 10-07-16 10:15, Ian Campbell wrote: On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote: Currently we fill ethaddr with a fixed unique address based on the SoCs serial (from the sid) to make sure that boards which use the integrated emac / gmac get a fixed mac rather then a random one

Re: [U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses

2016-07-10 Thread Ian Campbell
On Sat, 2016-07-09 at 15:12 +0200, Hans de Goede wrote: > Currently we fill ethaddr with a fixed unique address based on the > SoCs > serial (from the sid) to make sure that boards which use the > integrated > emac / gmac get a fixed mac rather then a random one. > > On some boards the wifi does n

[U-Boot] [PATCH v2] sunxi: Add support for multiple ethadrr-esses

2016-07-09 Thread Hans de Goede
Currently we fill ethaddr with a fixed unique address based on the SoCs serial (from the sid) to make sure that boards which use the integrated emac / gmac get a fixed mac rather then a random one. On some boards the wifi does not come with a fixed mac either, so we need to also set eth1addr. Thi