Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-06-08 Thread Mike Frysinger
On Tuesday, April 20, 2010 20:45:12 Thomas Chou wrote: > +void __led_init(led_id_t mask, int state) > +{ > + gpio_direction_output(mask, (state == STATUS_LED_ON) ? 0 : 1); > +} > + > +void __led_set(led_id_t mask, int state) > +{ > + gpio_set_value(mask, (state == STATUS_LED_ON) ? 0 : 1); >

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-05-04 Thread Thomas Chou
On 05/05/2010 06:30 AM, Wolfgang Denk wrote: > Dear Thomas Chou, > > In message<4bd7b0b3.3010...@wytron.com.tw> you wrote: > >> I sent a patch to enable some peripherals on the nios2-generic board. >> >> 04/28 [PATCH v2] nios2: add epcs, gpio led and mmc_spi to nios2-generic >> >> This patch s

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-05-04 Thread Scott McNutt
Dear Wolfgang, Wolfgang Denk wrote: > Dear Thomas Chou, > > In message <4bd7b0b3.3010...@wytron.com.tw> you wrote: >> I sent a patch to enable some peripherals on the nios2-generic board. >> >> 04/28 [PATCH v2] nios2: add epcs, gpio led and mmc_spi to nios2-generic >> >> This patch should be appl

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-05-04 Thread Wolfgang Denk
Dear Thomas Chou, In message <4bd7b0b3.3010...@wytron.com.tw> you wrote: > > I sent a patch to enable some peripherals on the nios2-generic board. > > 04/28 [PATCH v2] nios2: add epcs, gpio led and mmc_spi to nios2-generic > > This patch should be applied after the other outstanding patches. Ple

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-27 Thread Thomas Chou
On 04/26/2010 02:14 AM, Wolfgang Denk wrote: > As long as no board actually uses this code we should put that patch > on hold. Please resubmit it as part of the patch series that adds the > first board that uses this code. Thanks. > > Hi Wolfgang, I sent a patch to enable some peripherals on

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-25 Thread Wolfgang Denk
Dear Scott McNutt, In message <4bd39170.2040...@psyent.com> you wrote: > > >> I mean, which board in U-Boot uses this code? I didn't find any. > > I think the most accurate answer is both "all" and "none" ... and > I'm not trying to be funny or disrespectful in any way. It's just > so very easy

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-25 Thread Wolfgang Denk
Dear Thomas Chou, In message <4bd377c9.6010...@wytron.com.tw> you wrote: > > > The convention is not to add unused code. If there are no real users > > for this, the patch should be delayed until a board gets added that > > actually uses it. > > These nios2 boards are now supported with the nios2

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-24 Thread Scott McNutt
Hi Wolfgang, Thomas Chou wrote: > On 04/25/2010 06:32 AM, Wolfgang Denk wrote: >> >> I mean, which board in U-Boot uses this code? I didn't find any. I think the most accurate answer is both "all" and "none" ... and I'm not trying to be funny or disrespectful in any way. It's just so very easy to

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-24 Thread Thomas Chou
On 04/25/2010 06:32 AM, Wolfgang Denk wrote: > > I mean, which board in U-Boot uses this code? I didn't find any. > > The convention is not to add unused code. If there are no real users > for this, the patch should be delayed until a board gets added that > actually uses it. > > Hi Wolfgang,

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-24 Thread Wolfgang Denk
Dear Thomas Chou, In message <4bd36bae.2060...@wytron.com.tw> you wrote: > > >> This patch adds a status led driver followed the GPIO access > >> conventions of Linux. The led mask is used to specify the gpio pin. > >> > >> Signed-off-by: Thomas Chou > >> --- > >> Moved to drivers/misc. > >>

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-24 Thread Thomas Chou
On 04/25/2010 03:23 AM, Wolfgang Denk wrote: > Dear Thomas Chou, > > In message<1271810712-16238-1-git-send-email-tho...@wytron.com.tw> you wrote: > >> This patch adds a status led driver followed the GPIO access >> conventions of Linux. The led mask is used to specify the gpio pin. >> >> Sign

Re: [U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-24 Thread Wolfgang Denk
Dear Thomas Chou, In message <1271810712-16238-1-git-send-email-tho...@wytron.com.tw> you wrote: > This patch adds a status led driver followed the GPIO access > conventions of Linux. The led mask is used to specify the gpio pin. > > Signed-off-by: Thomas Chou > --- > Moved to drivers/misc. Whi

[U-Boot] [PATCH v2] misc: add gpio based status led driver

2010-04-20 Thread Thomas Chou
This patch adds a status led driver followed the GPIO access conventions of Linux. The led mask is used to specify the gpio pin. Signed-off-by: Thomas Chou --- Moved to drivers/misc. drivers/misc/Makefile |1 + drivers/misc/gpio_led.c | 30 ++ 2 files changed