Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-17 Thread Vipin Kumar
On 12/15/2012 12:29 AM, Scott Wood wrote: On 12/14/2012 03:23:26 AM, Vipin Kumar wrote: On 12/14/2012 3:22 AM, Scott Wood wrote: On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: + imgdata = malloc(read_size); + if (!imgdata) { +

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-14 Thread Scott Wood
On 12/14/2012 03:23:26 AM, Vipin Kumar wrote: On 12/14/2012 3:22 AM, Scott Wood wrote: On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: + imgdata = malloc(read_size); + if (!imgdata) { + printf("Not a

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-14 Thread Vipin Kumar
On 12/14/2012 3:22 AM, Scott Wood wrote: On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: Or better, just have one CONFIG_CMD_IMLS and have it operate on whatever flash types are configured into U-Boot. I didn't do it because until now the CONFIG_CMD_IMLS config is tightly bound with flash only

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-13 Thread Scott Wood
On 12/13/2012 12:10:58 AM, Vipin Kumar wrote: Or better, just have one CONFIG_CMD_IMLS and have it operate on whatever flash types are configured into U-Boot. I didn't do it because until now the CONFIG_CMD_IMLS config is tightly bound with flash only eg config_cmd_default.h enables CONFIG

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Vipin Kumar
[...] README | 3 +- common/cmd_bootm.c | 133 - 2 files changed, 134 insertions(+), 2 deletions(-) diff --git a/README b/README index 2077c3b..ec5c31e 100644 --- a/README +++ b/README @@ -831,7 +831,8 @@ The following opti

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Vipin Kumar
On 12/13/2012 1:54 AM, Wolfgang Denk wrote: Dear Vipin Kumar, In message you wrote: imls does not list the images in NAND devices. This patch implements this support for legacy type images. ... -static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) +static void do_i

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Scott Wood
On 12/12/2012 03:20:24 AM, Vipin Kumar wrote: imls does not list the images in NAND devices. This patch implements this support for legacy type images. Signed-off-by: Vipin Kumar --- Hello Scott, There has been sometime since you reviewed the first version of this patch. http://lists.denx

Re: [U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Wolfgang Denk
Dear Vipin Kumar, In message you wrote: > imls does not list the images in NAND devices. This patch implements this > support for legacy type images. ... > -static int do_imls(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) > +static void do_imls_flash(void) Why is this void? Shoul

[U-Boot] [PATCH v2] imls: Add support to list images in NAND device

2012-12-12 Thread Vipin Kumar
imls does not list the images in NAND devices. This patch implements this support for legacy type images. Signed-off-by: Vipin Kumar --- Hello Scott, There has been sometime since you reviewed the first version of this patch. http://lists.denx.de/pipermail/u-boot/2012-November/139631.html I am