Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-12-02 Thread Alexey Brodkin
On Mon, 2013-12-02 at 14:45 +0900, Jaehoon Chung wrote: > Hi, Rajeshwari > > It didn't need to include this patch. > > Best Regards, > Jaehoon Chung Agree, there's no need in this particular patch any more. Jaehoon Chung did appropriate changes in dwmmc driver. Thanks for collaboration. -Alexe

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-12-01 Thread Jaehoon Chung
Hi, Rajeshwari It didn't need to include this patch. Best Regards, Jaehoon Chung On 12/02/2013 02:39 PM, Rajeshwari Birje wrote: > Hi All, > > Iam a bit confused here. > After Jaehoon Chung has submitted the following patch: > "https://www.mail-archive.com/u-boot@lists.denx.de/msg126921.html";

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-12-01 Thread Rajeshwari Birje
Hi All, Iam a bit confused here. After Jaehoon Chung has submitted the following patch: "https://www.mail-archive.com/u-boot@lists.denx.de/msg126921.html"; Do we need to include this patch also? Regards, Rajeshwari Shinde. On Fri, Nov 29, 2013 at 5:46 PM, Alexey Brodkin wrote: >> All looks go

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
> All looks good from my side; > > Please do a boot test on the real hardware and let me know before > I can apply. > Hi Pantelis, confirming - builds/works good for me. -Alexey ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailma

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Pantelis Antoniou
Hi Alexey, On Nov 29, 2013, at 12:08 PM, Alexey Brodkin wrote: > On Fri, 2013-11-29 at 19:00 +0900, Jaehoon Chung wrote: >> remove this and use callback function like the host->board_init()? >> if (host->board_init()) >> host->board_init(host); >> >> Then we can reuse the this function for

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
On Fri, 2013-11-29 at 19:00 +0900, Jaehoon Chung wrote: > remove this and use callback function like the host->board_init()? > if (host->board_init()) > host->board_init(host); > > Then we can reuse the this function for board specific code. > Anyway, I think that exynos code didn't exist at

Re: [U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Jaehoon Chung
Hi Alexey, I have replied the previous patch. On 11/29/2013 06:39 PM, Alexey Brodkin wrote: > There's no point in having of "dwmmc.h" per architecure - we're talking > about device driver (DesignWare MMC controller) which is expected to > work with any CPU it is attached to. > > Actually this ch

[U-Boot] [PATCH v2] dwmmc: make driver usable for non-exynos platforms

2013-11-29 Thread Alexey Brodkin
There's no point in having of "dwmmc.h" per architecure - we're talking about device driver (DesignWare MMC controller) which is expected to work with any CPU it is attached to. Actually this change should have been an essential part of commit: === 6f0b7caa671f92c2d4676c84381d17fb90f7d2cd DWMM