Re: [U-Boot] [PATCH v2] davinci: cleanup davinci_sync_env_enetaddr() fucntion

2012-02-09 Thread Mike Frysinger
On Thursday 09 February 2012 07:16:21 Hadli, Manjunath wrote: > On Thu, Feb 09, 2012 at 09:48:55, Mike Frysinger wrote: > > On Wednesday 08 February 2012 06:14:35 Manjunath Hadli wrote: > > > - debug("### Setting environment from EEPROM MAC address = " > > > + printf("### Setting en

Re: [U-Boot] [PATCH v2] davinci: cleanup davinci_sync_env_enetaddr() fucntion

2012-02-09 Thread Hadli, Manjunath
Mike, On Thu, Feb 09, 2012 at 09:48:55, Mike Frysinger wrote: > On Wednesday 08 February 2012 06:14:35 Manjunath Hadli wrote: > > - debug("### Setting environment from EEPROM MAC address = " > > + printf("### Setting environment from EEPROM MAC address = " > > i don't think th

Re: [U-Boot] [PATCH v2] davinci: cleanup davinci_sync_env_enetaddr() fucntion

2012-02-08 Thread Mike Frysinger
On Wednesday 08 February 2012 06:14:35 Manjunath Hadli wrote: > - debug("### Setting environment from EEPROM MAC address = " > + printf("### Setting environment from EEPROM MAC address = " i don't think this should be displayed as this is the normal behavior ... otherwise,

[U-Boot] [PATCH v2] davinci: cleanup davinci_sync_env_enetaddr() fucntion

2012-02-08 Thread Manjunath Hadli
check for the return status for eth_getenv_enetaddr_by_index() and eth_setenv_enetaddr() functions and print appropriate message on failure. Also convert debug message to printf(). Signed-off-by: Manjunath Hadli Cc: Tom Rini Cc: Mike Frysinger Cc: Wolfgang Denk --- Changes for v2: Removed ad