Re: [U-Boot] [PATCH v2] crc32: Impl. linux optimized crc32()

2009-11-19 Thread Joakim Tjernlund
Mike Frysinger wrote on 19/11/2009 15:49:55: > > On Thursday 19 November 2009 07:31:18 Joakim Tjernlund wrote: > > Perhaps you can take a look at getting X_unaligned definitions > > into compiler.h too? > > that would be much trickier i think ... > > > I use get_unaligned() in the zlib patch I jus

Re: [U-Boot] [PATCH v2] crc32: Impl. linux optimized crc32()

2009-11-19 Thread Mike Frysinger
On Thursday 19 November 2009 07:31:18 Joakim Tjernlund wrote: > Perhaps you can take a look at getting X_unaligned definitions > into compiler.h too? that would be much trickier i think ... > I use get_unaligned() in the zlib patch I just sent: > [PATCH RFC] zlib: Optimize decompression > Not su

Re: [U-Boot] [PATCH v2] crc32: Impl. linux optimized crc32()

2009-11-19 Thread Joakim Tjernlund
Mike Frysinger wrote on 17/11/2009 05:06:02: > > On Monday 16 November 2009 23:01:59 Mike Frysinger wrote: > > On Friday 13 November 2009 03:52:05 Joakim Tjernlund wrote: > > > --- a/lib_generic/crc32.c > > > +++ b/lib_generic/crc32.c > > > @@ -13,6 +13,8 @@ > > > #else > > > #include > > > #e

Re: [U-Boot] [PATCH v2] crc32: Impl. linux optimized crc32()

2009-11-16 Thread Mike Frysinger
On Monday 16 November 2009 23:01:59 Mike Frysinger wrote: > On Friday 13 November 2009 03:52:05 Joakim Tjernlund wrote: > > --- a/lib_generic/crc32.c > > +++ b/lib_generic/crc32.c > > @@ -13,6 +13,8 @@ > > #else > > #include > > #endif > > +#include > > +#include > > the target system improv

Re: [U-Boot] [PATCH v2] crc32: Impl. linux optimized crc32()

2009-11-16 Thread Mike Frysinger
On Friday 13 November 2009 03:52:05 Joakim Tjernlund wrote: > --- a/lib_generic/crc32.c > +++ b/lib_generic/crc32.c > @@ -13,6 +13,8 @@ > #else > #include > #endif > +#include > +#include the target system improvements are awesome, but this breaks cross-compiling crc32 code for anything othe

[U-Boot] [PATCH v2] crc32: Impl. linux optimized crc32()

2009-11-13 Thread Joakim Tjernlund
Ported over the more efficient linux crc32() function. A quick comparsion on ppc: After changing the old crc32 to do 4 bytes in the inner loop to be able to compare with new version one can note: - old inner loop has 61 insn, new has 19 insn. - new crc32 does one 32 bit load of data to crc while