Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-29 Thread Detlev Zundel
Hi Wolfgang, [...] >> This change of the subject was the reason why I did not require you >> changing it as I know that Wolfgang currently matches patch versions by >> subject strings. > > This is not quite correct. I refer to the Subject: only if no other > thread information is present, i. e.

Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-29 Thread Detlev Zundel
Hi Macpaul, >> "Correct" threading however uses "References:" mail headers and can cope >> with changing subjects.  Somehow you seem to know this, as v3 indeed >> _has_ such a correct header and thus the threading in my mail reader >> works just fine ;) >> > > Yes. I did fix the References and In-

Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-29 Thread Wolfgang Denk
Dear Detlev Zundel, In message you wrote: > > > Since I've correct the subject of this patch v3 according to the > > "cosmetic" rule, > > it seems patch v3 is out of this mailing thread. > > This change of the subject was the reason why I did not require you > changing it as I know that Wolfgan

Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-29 Thread Macpaul Lin
Hi Detlev, > "Correct" threading however uses "References:" mail headers and can cope > with changing subjects.  Somehow you seem to know this, as v3 indeed > _has_ such a correct header and thus the threading in my mail reader > works just fine ;) > Yes. I did fix the References and In-reply-to

Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-29 Thread Detlev Zundel
Hi Macpaul, > Hi Detlev, > > 2011/4/27 Detlev Zundel : >> Hi Macpaul, >> >>> clean up with 2.6.38 checkpatch.pl >> >> There is indeed only one non-whitespace hunk in there: >> It's ok that you do the line wrapping, but actually with such lists we >> require alphabetical sorting of the clauses, so

Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-27 Thread Macpaul Lin
Hi Detlev, 2011/4/27 Detlev Zundel : > Hi Macpaul, > >> clean up with 2.6.38 checkpatch.pl > > There is indeed only one non-whitespace hunk in there: > It's ok that you do the line wrapping, but actually with such lists we > require alphabetical sorting of the clauses, so can you please juggle > t

Re: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-27 Thread Detlev Zundel
Hi Macpaul, > clean up with 2.6.38 checkpatch.pl There is indeed only one non-whitespace hunk in there: @@ -69,8 +69,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) defined(CONFIG_440SP) || defined(CONFIG_440SPE) print_str ("procfreq", strmhz(bu

[U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl

2011-04-26 Thread Macpaul Lin
clean up with 2.6.38 checkpatch.pl Signed-off-by: Macpaul Lin --- Changes for v2: - Correct the subject field to single patch. common/cmd_bdinfo.c | 295 ++- 1 files changed, 148 insertions(+), 147 deletions(-) diff --git a/common/cmd_bdinfo.c