Re: [U-Boot] [PATCH v2] cmd: fastboot: Validate user input

2018-08-13 Thread Sam Protsenko
Hi Lukasz, On Wed, Jul 25, 2018 at 12:22 AM, Lukasz Majewski wrote: > > Hi Sam, > > > On Sat, Jun 30, 2018 at 7:20 AM, Simon Glass wrote: > > > On 29 June 2018 at 11:59, Sam Protsenko > > > wrote: > > >> In case when user provides '-' as USB controller index, like this: > > >> > > >> => fas

Re: [U-Boot] [PATCH v2] cmd: fastboot: Validate user input

2018-07-24 Thread Lukasz Majewski
Hi Sam, > On Sat, Jun 30, 2018 at 7:20 AM, Simon Glass wrote: > > On 29 June 2018 at 11:59, Sam Protsenko > > wrote: > >> In case when user provides '-' as USB controller index, like this: > >> > >> => fastboot - > >> > >> data abort occurs in strcmp() function in do_fastboot(), here:

Re: [U-Boot] [PATCH v2] cmd: fastboot: Validate user input

2018-07-24 Thread Sam Protsenko
On Sat, Jun 30, 2018 at 7:20 AM, Simon Glass wrote: > On 29 June 2018 at 11:59, Sam Protsenko wrote: >> In case when user provides '-' as USB controller index, like this: >> >> => fastboot - >> >> data abort occurs in strcmp() function in do_fastboot(), here: >> >> if (!strcmp(argv[1], "u

Re: [U-Boot] [PATCH v2] cmd: fastboot: Validate user input

2018-07-12 Thread Sam Protsenko
Hi Tom, If there is no objections here, can we apply this patch? Thanks. On Sat, Jun 30, 2018 at 7:20 AM, Simon Glass wrote: > On 29 June 2018 at 11:59, Sam Protsenko wrote: >> In case when user provides '-' as USB controller index, like this: >> >> => fastboot - >> >> data abort occurs in

Re: [U-Boot] [PATCH v2] cmd: fastboot: Validate user input

2018-06-29 Thread Simon Glass
On 29 June 2018 at 11:59, Sam Protsenko wrote: > In case when user provides '-' as USB controller index, like this: > > => fastboot - > > data abort occurs in strcmp() function in do_fastboot(), here: > > if (!strcmp(argv[1], "udp")) > > (tested on BeagleBone Black). > > That's because arg

[U-Boot] [PATCH v2] cmd: fastboot: Validate user input

2018-06-29 Thread Sam Protsenko
In case when user provides '-' as USB controller index, like this: => fastboot - data abort occurs in strcmp() function in do_fastboot(), here: if (!strcmp(argv[1], "udp")) (tested on BeagleBone Black). That's because argv[1] is NULL when user types in the '-', and null pointer derefer