Hi Detlev,
On Wed, Nov 9, 2011 at 5:45 AM, Detlev Zundel wrote:
> Hi Graeme,
>
>> Hi Wolfgang
>>
>> On Wed, Nov 9, 2011 at 9:49 AM, Wolfgang Denk wrote:
>>> Dear Simon Glass,
>>>
>>> In message
>>> you
>>> wrote:
This discussion was regarding the need to #ifdef the variable declarat
Hi Wolfgang,
On Tue, Nov 8, 2011 at 2:49 PM, Wolfgang Denk wrote:
> Dear Simon Glass,
>
> In message
> you
> wrote:
>>
>> This discussion was regarding the need to #ifdef the variable declaration,
>> viz:
>>
>> #if defined(THING1) || defined(THING2)
>> const char *cat;
>> #endif
>>
>> ...
>>
Hi Graeme,
> Hi Wolfgang
>
> On Wed, Nov 9, 2011 at 9:49 AM, Wolfgang Denk wrote:
>> Dear Simon Glass,
>>
>> In message
>> you
>> wrote:
>>>
>>> This discussion was regarding the need to #ifdef the variable declaration,
>>> viz:
>>>
>>> #if defined(THING1) || defined(THING2)
>>> const char *c
Hi Wolfgang
On Wed, Nov 9, 2011 at 9:49 AM, Wolfgang Denk wrote:
> Dear Simon Glass,
>
> In message
> you
> wrote:
>>
>> This discussion was regarding the need to #ifdef the variable declaration,
>> viz:
>>
>> #if defined(THING1) || defined(THING2)
>> const char *cat;
>> #endif
>>
>> ...
>>
>
Dear Simon Glass,
In message
you wrote:
>
> This discussion was regarding the need to #ifdef the variable declaration,
> viz:
>
> #if defined(THING1) || defined(THING2)
> const char *cat;
> #endif
>
> ...
>
>
> #ifdef THING1
>cat = getenv("cat");
>
>send_back(cat);
> #endif
>
>
>
Hi Albert,
On Tue, Nov 8, 2011 at 11:46 AM, Albert ARIBAUD
wrote:
> Le 08/11/2011 16:57, Simon Glass a écrit :
>>
>> Hi Detlev,
>>
>> On Tue, Nov 8, 2011 at 1:20 AM, Detlev Zundel wrote:
>>>
>>> Hi Mike,
>>>
On Monday 31 October 2011 17:06:46 Simon Glass wrote:
>
> On Sun, Oct 30, 2
Le 08/11/2011 16:57, Simon Glass a écrit :
> Hi Detlev,
>
> On Tue, Nov 8, 2011 at 1:20 AM, Detlev Zundel wrote:
>> Hi Mike,
>>
>>> On Monday 31 October 2011 17:06:46 Simon Glass wrote:
On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote:
> On Sunday 23 October 2011 23:44:35 Simon Glass
Hi Detlev,
On Tue, Nov 8, 2011 at 1:20 AM, Detlev Zundel wrote:
> Hi Mike,
>
>> On Monday 31 October 2011 17:06:46 Simon Glass wrote:
>>> On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote:
>>> > On Sunday 23 October 2011 23:44:35 Simon Glass wrote:
>>> >> --- a/arch/arm/lib/board.c
>>> >> +++
Hi Mike,
> On Monday 31 October 2011 17:06:46 Simon Glass wrote:
>> On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote:
>> > On Sunday 23 October 2011 23:44:35 Simon Glass wrote:
>> >> --- a/arch/arm/lib/board.c
>> >> +++ b/arch/arm/lib/board.c
>> >>
>> >> flash_size = flash_init();
>> >
On Monday 31 October 2011 17:06:46 Simon Glass wrote:
> On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote:
> > On Sunday 23 October 2011 23:44:35 Simon Glass wrote:
> >> --- a/arch/arm/lib/board.c
> >> +++ b/arch/arm/lib/board.c
> >>
> >> flash_size = flash_init();
> >> if (flash_s
Hi Mike,
On Sun, Oct 30, 2011 at 5:44 PM, Mike Frysinger wrote:
> On Sunday 23 October 2011 23:44:35 Simon Glass wrote:
>> --- a/arch/arm/lib/board.c
>> +++ b/arch/arm/lib/board.c
>>
>> flash_size = flash_init();
>> if (flash_size > 0) {
>> # ifdef CONFIG_SYS_FLASH_CHECKSUM
>> +
On Sunday 23 October 2011 23:44:35 Simon Glass wrote:
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
>
> flash_size = flash_init();
> if (flash_size > 0) {
> # ifdef CONFIG_SYS_FLASH_CHECKSUM
> + char *s = getenv("flashchecksum");
> +
> print_size(f
On Tue, Oct 25, 2011 at 12:36 PM, Wolfgang Denk wrote:
> Dear Albert ARIBAUD,
>
> In message <4ea6fe3b.9080...@aribaud.net> you wrote:
>>
>> >> I've just fetched u-boot and I don't see this one. Can you push
>> >> u-boot/master so that I can rebase u-boot-arm/master on it and launch
>> >> some tes
Dear Albert ARIBAUD,
In message <4ea6fe3b.9080...@aribaud.net> you wrote:
>
> >> I've just fetched u-boot and I don't see this one. Can you push
> >> u-boot/master so that I can rebase u-boot-arm/master on it and launch
> >> some tests?
> >
> > Done.
>
> Hmm... Weird. I've just fetched u-Boot aga
Hi Albert,
On Tue, Oct 25, 2011 at 11:21 AM, Albert ARIBAUD
wrote:
> Le 25/10/2011 09:50, Wolfgang Denk a écrit :
>>
>> Dear Albert ARIBAUD,
>>
>> In message<4ea65cbf.7060...@aribaud.net> you wrote:
>>>
>>> I've just fetched u-boot and I don't see this one. Can you push
>>> u-boot/master so that
Le 25/10/2011 09:50, Wolfgang Denk a écrit :
> Dear Albert ARIBAUD,
>
> In message<4ea65cbf.7060...@aribaud.net> you wrote:
>>
>> I've just fetched u-boot and I don't see this one. Can you push
>> u-boot/master so that I can rebase u-boot-arm/master on it and launch
>> some tests?
>
> Done.
Hmm..
Dear Albert ARIBAUD,
In message <4ea65cbf.7060...@aribaud.net> you wrote:
>
> I've just fetched u-boot and I don't see this one. Can you push
> u-boot/master so that I can rebase u-boot-arm/master on it and launch
> some tests?
Done.
Best regards,
Wolfgang Denk
--
DENX Software Engineering
Hi Wolfgang,
Le 24/10/2011 21:13, Wolfgang Denk a écrit :
> Dear Simon Glass,
>
> In message<1319427875-29965-1-git-send-email-...@chromium.org> you wrote:
>> Commit dc8bbea removed a local variable that is used in most ARM boards.
>>
>> Since we want to avoid an 'unused variable' warning with la
Dear Simon Glass,
In message <1319427875-29965-1-git-send-email-...@chromium.org> you wrote:
> Commit dc8bbea removed a local variable that is used in most ARM boards.
>
> Since we want to avoid an 'unused variable' warning with later compilers,
> and the #ifdef logic of whether this variable is
Commit dc8bbea removed a local variable that is used in most ARM boards.
Since we want to avoid an 'unused variable' warning with later compilers,
and the #ifdef logic of whether this variable is required is bit painful,
this declares the variable local to the block of code that needs it.
Signed-
20 matches
Mail list logo
