> -Original Message-
> From: Kushwaha Prabhakar-B32579
> Sent: Thursday, August 20, 2015 9:33 AM
> To: Tang Yuantian-B29983; Sun York-R58495
> Cc: u-boot@lists.denx.de; Wang Huan-B18965
> Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
>
> > -Original Messa
> -Original Message-
> From: Tang Yuantian-B29983
> Sent: Thursday, August 20, 2015 6:52 AM
> To: Kushwaha Prabhakar-B32579 ; Sun York-
> R58495
> Cc: u-boot@lists.denx.de; Wang Huan-B18965
> Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
>
>
>
> > -Orig
> -Original Message-
> From: Kushwaha Prabhakar-B32579
> Sent: Wednesday, August 19, 2015 8:54 PM
> To: Tang Yuantian-B29983; Sun York-R58495
> Cc: u-boot@lists.denx.de; Wang Huan-B18965
> Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
>
>
>
> Regards,
> Pra
Regards,
Prabhakar
> -Original Message-
> From: Tang Yuantian-B29983
> Sent: Wednesday, August 19, 2015 10:17 AM
> To: Kushwaha Prabhakar-B32579; Sun York-R58495
> Cc: u-boot@lists.denx.de; Wang Huan-B18965
> Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
>
>
OK, I will work with Prabhakar on this.
This is freescale specific settings and workaround. Other boards out of
freescale don't use this.
Regards,
Yuantian
From: Sun York-R58495
Sent: Wednesday, August 19, 2015 12:47 PM
To: Tang Yuantian-B29983
Cc: u-boot@lists.denx.de; Kushwaha Prabhakar-B3257
> -Original Message-
> From: Kushwaha Prabhakar-B32579
> Sent: Wednesday, August 19, 2015 12:15 PM
> To: Tang Yuantian-B29983; Sun York-R58495
> Cc: u-boot@lists.denx.de; Wang Huan-B18965
> Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
>
>
> > -Original
No, the old patch still use board files. Even it is a common board file, it is
not common for other than freescale boards.
ls2085 didn't have an soc file to start with. When you have a situation like
this, you create one. I will be out in next few days, please work with
Prabhakar.
York
__
On ls2085 we had a soc file which can put all the soc specific function in it.
But on ls1021, there is no such file unless I create one for SATA.
Please see the patch I first submit. Do you prefer this way?
http://patchwork.ozlabs.org/patch/497983/
Regards,
Yuantian
From: Sun York-R58495
Sent: W
That's exactly what I mean. It is ls1021 soc erratum, not board specific.
York
Original message
From: Tang Yuantian-B29983
Date:08/18/2015 21:36 (GMT-08:00)
To: Sun York-R58495
Cc: u-boot@lists.denx.de, Kushwaha Prabhakar-B32579 , Wang Huan-B18965
Subject: RE: [PATCH v2] arm/ls
Yes, this is a ls1021 specific errata.
Maybe we need to name the errata micro better.
Regards,
Yuantian
From: Sun York-R58495
Sent: Wednesday, August 19, 2015 11:57 AM
To: Tang Yuantian-B29983
Cc: u-boot@lists.denx.de; Kushwaha Prabhakar-B32579; Wang Huan-B18965
Subject: Re: [PATCH v2] arm/ls1021
> -Original Message-
> From: Tang Yuantian-B29983
> Sent: Wednesday, August 19, 2015 8:01 AM
> To: Sun York-R58495
> Cc: u-boot@lists.denx.de; Kushwaha Prabhakar-B32579; Wang Huan-B18965
> Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
>
> > > +#ifdef CONFIG_SY
Yuantian,
In your patch, you are using CONFIG_SYS_FSL_ERRATUM_A008407. Are you saying
this is a board erratum, not an SoC erratum?
York
From: Tang Yuantian-B29983
Sent: Tuesday, August 18, 2015 8:47 PM
To: Sun York-R58495
Cc: u-boot@lists.denx.de; Kushwaha Pr
I don't understand. This workaround is our board specific and actually ls1021
specific. I thought about merging all the LS SATA initialization into one file,
but that didn't reduce many code. So I add this one by one board.
Regards,
Yuantian
From: Sun York-R58495
Sent: Wednesday, August 19, 201
The soc workarounds belongs to soc file, not board file, so you don't have to
copy the code to every board. Our boards are not the only boards with this SoC.
York
Original message
From: Tang Yuantian-B29983
Date:08/18/2015 20:34 (GMT-08:00)
To: Sun York-R58495
Cc: u-boot@lists
From: Sun York-R58495
Sent: Wednesday, August 19, 2015 10:42 AM
To: Tang Yuantian-B29983; Sun York-R58495
Cc: u-boot@lists.denx.de; Kushwaha Prabhakar-B32579; Wang Huan-B18965
Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr board
Sorry for top posting, replying from my phone
OK, I will updated this patch.
Regards,
Yuantian
From: Sun York-R58495
Sent: Wednesday, August 19, 2015 10:42 AM
To: Tang Yuantian-B29983; Sun York-R58495
Cc: u-boot@lists.denx.de; Kushwaha Prabhakar-B32579; Wang Huan-B18965
Subject: RE: [PATCH v2] arm/ls1021a: Add sata support on qds and twr bo
Sorry for top posting, replying from my phone.
Please use macros instead of numbers. It's still better than putting magic
numbers in the code. And please move it out of board files.
York
Original message
From: Tang Yuantian-B29983
Date:08/18/2015 19:31 (GMT-08:00)
To: Sun Yor
> > +#ifdef CONFIG_SYS_FSL_ERRATUM_A008407
> > +#define SATA_ECC_REG_ADDR 0x20220520
> > + unsigned int __iomem *ecc_reg = (void *)SATA_ECC_REG_ADDR;
> #endif
> > +
> > + out_le32(&ccsr_ahci->ppcfg, 0xa003fffe);
> > + out_le32(&ccsr_ahci->pp2c, 0x28183411);
> > + out_le32(&ccsr_ahci->pp3c,
On 08/17/2015 02:42 AM, yuantian.t...@freescale.com wrote:
> From: Tang Yuantian
>
> Freescale ARM-based Layerscape LS102xA contain a SATA controller
> which comply with the serial ATA 3.0 specification and the
> AHCI 1.3 specification.
> This patch adds SATA feature on ls1021aqds and ls1021atw
From: Tang Yuantian
Freescale ARM-based Layerscape LS102xA contain a SATA controller
which comply with the serial ATA 3.0 specification and the
AHCI 1.3 specification.
This patch adds SATA feature on ls1021aqds and ls1021atwr boards.
Signed-off-by: Tang Yuantian
---
v2:
- rebase to late
20 matches
Mail list logo
