Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-13 Thread Albert ARIBAUD
Hello Bin, On Fri, 13 Nov 2015 17:08:22 +0800, Bin Meng wrote: > Hi Albert, > > > + subl%esp, %eax > > I guess you are confused by the AT&T assembly syntax. This should be: > subl %eax, %esp. > > + subl%esp, %eax > > Ditto. Thanks -- last time I touched Intel assembly was

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-13 Thread Bin Meng
Hi Albert, On Wed, Nov 11, 2015 at 2:30 AM, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it ls actually already using. This is not a valid > C runtime environment. > > Split board_init_f_mem into C functions which do not > alter their own stack and therefo

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-13 Thread Thomas Chou
Hi Albert, On 2015年11月13日 14:41, Albert ARIBAUD wrote: Hello Thomas, On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou wrote: Hi Albert, - /* Update stack- and frame-pointers */ - mov sp, r2 - mov fp, sp Just a sec here on second thought. I understand the 'mov sp

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-12 Thread Albert ARIBAUD
Hello Thomas, On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou wrote: > Hi Albert, > - /* Update stack- and frame-pointers */ > - mov sp, r2 > - mov fp, sp Just a sec here on second thought. I understand the 'mov sp, r2' must be removed as it is replaced by a 'sub sp, sp, r2

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-12 Thread Albert ARIBAUD
Hello Thomas, On Thu, 12 Nov 2015 16:28:38 +0800, Thomas Chou wrote: > Hi Albert, > > On 2015年11月12日 15:17, Albert ARIBAUD wrote: > >> > >> diff --git a/common/init/board_init.c b/common/init/board_init.c > >> index 8839a4a

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-12 Thread Thomas Chou
Hi Albert, On 2015年11月12日 15:17, Albert ARIBAUD wrote: diff --git a/common/init/board_init.c b/common/init/board_init.c index 8839a4a..703e6d8 100644 --- a/common/init/board_init.c +++ b/common/init/board_init.c @@ -46,6 +4

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-11 Thread Albert ARIBAUD
Hello Thomas, On Thu, 12 Nov 2015 13:59:28 +0800, Thomas Chou wrote: > Hi Albert, > > On 2015年11月11日 02:30, Albert ARIBAUD wrote: > > board_init_f_mem() alters the C runtime environment's > > stack it ls actually already using. This is not a valid > > C runtime environment. > > > > Split board_i

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-11 Thread Thomas Chou
Hi Albert, On 2015年11月11日 02:30, Albert ARIBAUD wrote: board_init_f_mem() alters the C runtime environment's stack it ls actually already using. This is not a valid C runtime environment. Split board_init_f_mem into C functions which do not alter their own stack and therefore run in a valid C r

Re: [U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-11 Thread Albert ARIBAUD
On Tue, 10 Nov 2015 19:30:47 +0100, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it ls actually already using. This is not a valid > C runtime environment. > > Split board_init_f_mem into C functions which do not > alter their own stack and therefore run i

[U-Boot] [PATCH v2] Fix board init code to use a valid C runtime environment

2015-11-10 Thread Albert ARIBAUD
board_init_f_mem() alters the C runtime environment's stack it ls actually already using. This is not a valid C runtime environment. Split board_init_f_mem into C functions which do not alter their own stack and therefore run in a valid C runtime environment. Signed-off-by: Albert ARIBAUD --- Fo