Hello Tapani,
On Tue, May 28, 2013 at 5:04 AM, Tapani Utriainen wrote:
>
> Add support for Wandboard quad.
>
> Signed-off-by: Tapani Utriainen
Can you handle the comments done by Wolfgang and Stefano?
It'd be very good to have it merged for 2013.07 but we're getting short on time.
--
Otavio S
Dear Otavio,
In message
you wrote:
>
> > Please do NOT use these terrible SZ_* defines. Never, ever.
> >
> > They are dangerous and should be avoided.
> >
>
> Do you mind to explain why?
Well, what does "SZ_1M" mean? Is it 1000 * 1000 (as on hard disk
drives) or 1000 * 1024 (as on floppy d
On Mon, Jun 3, 2013 at 8:21 AM, Wolfgang Denk wrote:
> Dear Stefano Babic,
>
> In message <51ac61a6.9050...@denx.de> you wrote:
> >
> > It is better to fix it directly into this patch. Can you fix it by
> > casting to phys_size_t and resubmit ?
> >
> > gd->ram_size = (phys_size_t)CONFIG_DDR
Dear Stefano Babic,
In message <51ac61a6.9050...@denx.de> you wrote:
>
> It is better to fix it directly into this patch. Can you fix it by
> casting to phys_size_t and resubmit ?
>
> gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;
Please do NOT use these terrible SZ_* defines. Neve
Hi Tapani,
On 28/05/2013 10:04, Tapani Utriainen wrote:
>
> Add support for Wandboard quad.
>
> Signed-off-by: Tapani Utriainen
> ---
Due to increased memory, a warning is generated for wandboard_quad:
wandboard.c: In function 'dram_init':
wandboard.c:47:31: warning: integer overflow in expre
On Tue, May 28, 2013 at 5:04 AM, Tapani Utriainen wrote:
>
> Add support for Wandboard quad.
>
> Signed-off-by: Tapani Utriainen
>
Acked-by: Otavio Salvador
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://projetos.ossystems.com.br
Mobile:
Add support for Wandboard quad.
Signed-off-by: Tapani Utriainen
---
Changes from v1:
- reorganized the board names into alphabetical order
- added quad entry to the Wandboard README
board/wandboard/README | 5 +
boards.cfg | 1 +
include/configs/wandboard.h | 2 ++
7 matches
Mail list logo
