Re: [U-Boot] [PATCH v2] Add 16-bit single register pin controller support

2017-04-18 Thread James Balean
Hi Felix, On 7 April 2017 at 23:22, Felix Brack wrote: > You should though read my comment as there is some more work to be > done. Thank you for your suggestions despite my incorrect submission. I now see and agree that it would be better to have the code inline in the `single_configure_pins()`

Re: [U-Boot] [PATCH v2] Add 16-bit single register pin controller support

2017-04-07 Thread Felix Brack
Hello James, Sorry I missed your followup. Please always send to 'everybody' and not just the list. You should though read my comment as there is some more work to be done. regards Felix On 07.04.2017 03:44, James Balean wrote: > Apologies! Just noticed I submitted the untested patch update. I'l

Re: [U-Boot] [PATCH v2] Add 16-bit single register pin controller support

2017-04-07 Thread Felix Brack
Hello James, This patch does not compile without errors. On 06.04.2017 07:38, James Balean wrote: > Enables the pinctrl-single driver to support 16-bit registers. Only > 32-bit registers were supported previously. Reduced width registers are > required for some platforms, such as OMAP. > > Signe

Re: [U-Boot] [PATCH v2] Add 16-bit single register pin controller support

2017-04-06 Thread James Balean
Apologies! Just noticed I submitted the untested patch update. I'll gather suggestions on this (note that 'size' in the first switch should be 'width' and there's a trailing bracket missing), then submit a (hopefully) final version. James ___ U-Boot mai

[U-Boot] [PATCH v2] Add 16-bit single register pin controller support

2017-04-05 Thread James Balean
Enables the pinctrl-single driver to support 16-bit registers. Only 32-bit registers were supported previously. Reduced width registers are required for some platforms, such as OMAP. Signed-off-by: James Balean Cc: Felix Brack Cc: Simon Glass --- Changes for v2: - Added explanation of why thi