Re: [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long".

2008-09-11 Thread Haavard Skinnemoen
On Tue, 9 Sep 2008 02:08:31 +0200 Wolfgang Denk <[EMAIL PROTECTED]> wrote: > From: Sergei Poselenov <[EMAIL PROTECTED]> > > Signed-off-by: Sergei Poselenov <[EMAIL PROTECTED]> > Signed-off-by: Wolfgang Denk <[EMAIL PROTECTED]> > --- > > With some (more recent) compiler versions there are proble

Re: [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long".

2008-09-09 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > > > + do_div(val, (data[i][0] - data[i-1][0])); > > Looking at how do_div() is defined, and it handles its parameters > carefully, one shouldn't need the extra parenthesis here, i.e., The are not exactly need (and actual

Re: [U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long".

2008-09-09 Thread Guennadi Liakhovetski
On Tue, 9 Sep 2008, Wolfgang Denk wrote: > diff --git a/board/trab/tsc2000.c b/board/trab/tsc2000.c > index 382a85b..f13a5a9 100644 > --- a/board/trab/tsc2000.c > +++ b/board/trab/tsc2000.c > @@ -27,6 +27,7 @@ > > #include > #include > +#include > #include "tsc2000.h" > > #include "Pt10

[U-Boot] [PATCH v2] ARM: Use do_div() instead of division for "long long".

2008-09-08 Thread Wolfgang Denk
From: Sergei Poselenov <[EMAIL PROTECTED]> Signed-off-by: Sergei Poselenov <[EMAIL PROTECTED]> Signed-off-by: Wolfgang Denk <[EMAIL PROTECTED]> --- With some (more recent) compiler versions there are problems because of the use of "long long" divisions in the U-Boot code. For ARM, this requires t