Re: [U-Boot] [PATCH v2] ADS5121 NAND driver

2008-10-31 Thread Scott Wood
On Wed, Oct 29, 2008 at 05:37:52PM -0600, John Rigby wrote: > Scott, thanks for your feedback. I can easily fix most of the issues. > > The one question I have is if this can go in only supporting 5121 rev2. > If I need to add rev1 support it will take more time than I have right now. If rev1

Re: [U-Boot] [PATCH v2] ADS5121 NAND driver

2008-10-30 Thread Wolfgang Denk
Dear John, In message <[EMAIL PROTECTED]> you wrote: > > The one question I have is if this can go in only supporting 5121 rev2. > If I need to add rev1 support it will take more time than I have right now. I think it is perfectly OK to support only Rev. 2 (and later) of the chip. Rev. 1 i

Re: [U-Boot] [PATCH v2] ADS5121 NAND driver

2008-10-29 Thread John Rigby
Scott, thanks for your feedback. I can easily fix most of the issues. The one question I have is if this can go in only supporting 5121 rev2. If I need to add rev1 support it will take more time than I have right now. Thanks John > Scott Wood wrote: > John Rigby wrote: > >> ADS5121 r

Re: [U-Boot] [PATCH v2] ADS5121 NAND driver

2008-10-29 Thread Scott Wood
John Rigby wrote: > ADS5121 rev4 / MPC5121e rev2 only What is unique about that revision that it cannot share a driver? It certainly shouldn't be board-specific... > This controller treats 2K pages as 4 512 byte pages > and the hw ecc is over the combined 512 byte main > area and the first 7 byt