Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-07 Thread Albert ARIBAUD
Hi, Le 05/01/2011 06:27, Minkyu Kang a écrit : > How about v1 patch for NULL pointer. > Do you agreed with this patch? > http://patchwork.ozlabs.org/patch/76784/ This one I'm okay with; please repost as a non-RFC, simple, [PATCH]. > If so, I'm going to make a patch for all of ARM CPUs. That wo

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Minkyu Kang
On 5 January 2011 02:02, Albert ARIBAUD wrote: > (sending again, this time to the list) > > Le 04/01/2011 12:02, Minkyu Kang a écrit : > Some bss variables are initialized to 0x in my test case. In this case we should skip the fixup too. So, I make v2 patch for check it. >>>

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Albert ARIBAUD
(sending again, this time to the list) Le 04/01/2011 12:02, Minkyu Kang a écrit : >>> Some bss variables are initialized to 0x in my test case. >>> In this case we should skip the fixup too. >>> So, I make v2 patch for check it. >> >> 0x? What variables? Feels like a some other bu

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Joakim Tjernlund
Minkyu Kang wrote on 2011/01/04 12:02:29: > > Dear Joakim Tjernlund, > > On 4 January 2011 19:31, Joakim Tjernlund > wrote: > > Minkyu Kang wrote on 2011/01/04 11:04:57: > >> > >> Dear Joakim Tjernlund, > >> > >> On 4 January 2011 18:49, Joakim Tjernlund > >> wrote: > >> >> > >> >> Need to ch

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Minkyu Kang
Dear Joakim Tjernlund, On 4 January 2011 19:31, Joakim Tjernlund wrote: > Minkyu Kang wrote on 2011/01/04 11:04:57: >> >> Dear Joakim Tjernlund, >> >> On 4 January 2011 18:49, Joakim Tjernlund >> wrote: >> >> >> >> Need to check that location is valid on RAM before the fixup. >> > >> > Why thi

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Joakim Tjernlund
Minkyu Kang wrote on 2011/01/04 11:04:57: > > Dear Joakim Tjernlund, > > On 4 January 2011 18:49, Joakim Tjernlund > wrote: > >> > >> Need to check that location is valid on RAM before the fixup. > > > > Why this change? The [PATCH RFC] armv7: fixloop: don't fixup if location is > > NULL > > sh

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Minkyu Kang
Dear Joakim Tjernlund, On 4 January 2011 18:49, Joakim Tjernlund wrote: >> >> Need to check that location is valid on RAM before the fixup. > > Why this change? The [PATCH RFC] armv7: fixloop: don't fixup if location is > NULL > should be what you need. Some bss variables are initialized to 0xf

Re: [U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Joakim Tjernlund
> > Need to check that location is valid on RAM before the fixup. Why this change? The [PATCH RFC] armv7: fixloop: don't fixup if location is NULL should be what you need. You could mention what causes these NULL fixups, here is commit entry for powerpc: powerpc: do not fixup NULL ptrs The f

[U-Boot] [PATCH v2, RFC] armv7: fixloop: don't fixup if location is invalid on RAM

2011-01-04 Thread Minkyu Kang
Need to check that location is valid on RAM before the fixup. Signed-off-by: Minkyu Kang --- arch/arm/cpu/armv7/start.S |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/arch/arm/cpu/armv7/start.S b/arch/arm/cpu/armv7/start.S index 684f2d2..a052378 100644 --- a/arch/a