Re: [U-Boot] [PATCH v15 2/4] efi: Split out test init/uninit into functions

2018-11-24 Thread Simon Glass
Hi Heinrich, On Fri, 23 Nov 2018 at 16:23, Heinrich Schuchardt wrote: > > On 11/22/18 9:46 PM, Simon Glass wrote: > > The functions in bootefi are very long because they mix high-level code > > and control with the low-level implementation. To help with this, create > > functions which handle pre

Re: [U-Boot] [PATCH v15 2/4] efi: Split out test init/uninit into functions

2018-11-23 Thread Heinrich Schuchardt
On 11/22/18 9:46 PM, Simon Glass wrote: > The functions in bootefi are very long because they mix high-level code > and control with the low-level implementation. To help with this, create > functions which handle preparing for running the test and cleaning up > afterwards. > > Also shorten the aw

[U-Boot] [PATCH v15 2/4] efi: Split out test init/uninit into functions

2018-11-22 Thread Simon Glass
The functions in bootefi are very long because they mix high-level code and control with the low-level implementation. To help with this, create functions which handle preparing for running the test and cleaning up afterwards. Also shorten the awfully long variable names here. Signed-off-by: Simo