Re: [U-Boot] [PATCH v11 4/6] efi: Split out test init/uninit into functions

2018-11-04 Thread Simon Glass
HI Heinrich, On 15 October 2018 at 11:34, Heinrich Schuchardt wrote: > On 10/15/2018 04:17 PM, Simon Glass wrote: >> The functions in bootefi are very long because they mix high-level code >> and control with the low-level implementation. To help with this, create >> functions which handle prepar

Re: [U-Boot] [PATCH v11 4/6] efi: Split out test init/uninit into functions

2018-10-15 Thread Heinrich Schuchardt
On 10/15/2018 04:17 PM, Simon Glass wrote: > The functions in bootefi are very long because they mix high-level code > and control with the low-level implementation. To help with this, create > functions which handle preparing for running the test and cleaning up > afterwards. > > Also shorten the

[U-Boot] [PATCH v11 4/6] efi: Split out test init/uninit into functions

2018-10-15 Thread Simon Glass
The functions in bootefi are very long because they mix high-level code and control with the low-level implementation. To help with this, create functions which handle preparing for running the test and cleaning up afterwards. Also shorten the awfully long variable names here. Signed-off-by: Simo