Re: [U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok

2018-10-18 Thread Heinrich Schuchardt
On 10/19/2018 05:25 AM, Simon Glass wrote: > Hi, > > On 15 October 2018 at 11:16, Heinrich Schuchardt wrote: >> On 10/15/2018 04:17 PM, Simon Glass wrote: >>> This value is stored in data which appears to be read-only with sandbox on >>> my Ubuntu 18.04 machine. In any case it is not good practic

Re: [U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok

2018-10-18 Thread Simon Glass
Hi, On 15 October 2018 at 11:16, Heinrich Schuchardt wrote: > On 10/15/2018 04:17 PM, Simon Glass wrote: >> This value is stored in data which appears to be read-only with sandbox on >> my Ubuntu 18.04 machine. In any case it is not good practice to store >> run-time data in a build-time linker l

Re: [U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok

2018-10-15 Thread Heinrich Schuchardt
On 10/15/2018 04:17 PM, Simon Glass wrote: > This value is stored in data which appears to be read-only with sandbox on > my Ubuntu 18.04 machine. In any case it is not good practice to store > run-time data in a build-time linker list. Yes this should be changed. Otherwise a reset of the board wil

[U-Boot] [PATCH v11 2/6] efi_loader: Drop setup_ok

2018-10-15 Thread Simon Glass
This value is stored in data which appears to be read-only with sandbox on my Ubuntu 18.04 machine. In any case it is not good practice to store run-time data in a build-time linker list. The value does not seem to be that useful, since tests that fail to setup are likely to fail to run also. Let'