Re: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-17 Thread Stefan
> Unfortunately the only documentation we have on the sun7i DRAM > controller is Allwinner boot0 + boot1 code, and that code uses.. magic > numbers & shifts with no explanations. To avoid having to explain this over-and-over again, the code could include some comment(s) pointing out that these are

Re: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-14 Thread Tom Rini
On Fri, Mar 14, 2014 at 12:23:50PM -0500, Alex G. wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/14/2014 09:17 AM, Tom Rini wrote: > > On Fri, Mar 14, 2014 at 10:33:45AM +, Ian Campbell wrote: > > > > [snip] > >> +static void mctl_ddr3_reset(void) +{ +struct sunxi_dram

Re: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-14 Thread Alex G.
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2014 09:17 AM, Tom Rini wrote: > On Fri, Mar 14, 2014 at 10:33:45AM +, Ian Campbell wrote: > > [snip] >> +static void mctl_ddr3_reset(void) +{ + struct sunxi_dram_reg >> *dram = +(struct sunxi_dram_reg *)SUNXI_DR

Re: [U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-14 Thread Tom Rini
On Fri, Mar 14, 2014 at 10:33:45AM +, Ian Campbell wrote: [snip] > +static void mctl_ddr3_reset(void) > +{ > + struct sunxi_dram_reg *dram = > + (struct sunxi_dram_reg *)SUNXI_DRAMC_BASE; > + > + { > + clrbits_le32(&dram->mcr, DRAM_MCR_RESET); > +

[U-Boot] [PATCH v1 3/9] sunxi: initial sun7i dram setup support

2014-03-14 Thread Ian Campbell
Based linux-sunxi#sunxi commit d854c4de2f57 "arm: Handle .gnu.hash section in ldscripts" vs v2014.01. This has been stripped back for mainlining and supports only sun7i. These changes are not useful by themselves but are split out to make the patch sizes more manageable. As well as the following