Re: [U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

2013-06-03 Thread Wolfgang Denk
Dear Gerhard Sittig, In message <20130603135004.gh2...@book.gsilab.sittig.org> you wrote: > > > > + if (mac_diag) > > > + printf("DIAG: MAC [%s]\n", getenv("ethaddr")); > > > > What happens if "ethaddr" is not defined in the environment? > > The context is the mac_read_fr

Re: [U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

2013-06-03 Thread Gerhard Sittig
On Mon, Jun 03, 2013 at 15:31 +0200, Stefano Babic wrote: > > On 03/06/2013 13:10, Gerhard Sittig wrote: > > > - s = getenv("install_in_progress"); > > + s = getenv("want_recovery"); > > if ((s != NULL) && (*s != '\0')) { > > - printf("previous installation aborted, running RECO

Re: [U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

2013-06-03 Thread Gerhard Sittig
On Mon, Jun 03, 2013 at 15:07 +0200, Wolfgang Denk wrote: > > In message <1370257851-27583-1-git-send-email-...@denx.de> you wrote: > > > > + if (mac_diag) > > + printf("DIAG: MAC [%s]\n", getenv("ethaddr")); > > What happens if "ethaddr" is not defined in the environm

Re: [U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

2013-06-03 Thread Stefano Babic
Hi Gerhard, On 03/06/2013 13:10, Gerhard Sittig wrote: > - s = getenv("install_in_progress"); > + s = getenv("want_recovery"); > if ((s != NULL) && (*s != '\0')) { > - printf("previous installation aborted, running RECOVERY\n"); > + printf("detected recovery

Re: [U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

2013-06-03 Thread Wolfgang Denk
Dear Gerhard, In message <1370257851-27583-1-git-send-email-...@denx.de> you wrote: > > + if (mac_diag) > + printf("DIAG: MAC [%s]\n", getenv("ethaddr")); What happens if "ethaddr" is not defined in the environment? ... > + "rootpath=/opt/eldk/ppc_6xx\0"

[U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

2013-06-03 Thread Gerhard Sittig
minor improvements for the 'ifm AC14xx' board setup - adjust diagnostics (reworded, silent by default) - re-order the list of "recovery conditions" - update and improve comments - adjust the board configuration - use the builtin serial baudrate table - use the official 'ac14xx' name everywhere