Re: [U-Boot] [PATCH v1 02/15] fs/fat: implement readdir

2017-08-12 Thread Alexander Graf
> Am 12.08.2017 um 16:04 schrieb Rob Clark : > >> On Sat, Aug 12, 2017 at 8:17 AM, Alexander Graf wrote: >> >> >>> On 10.08.17 20:29, Rob Clark wrote: >>> >>> Yes, this is super-hacky. The FAT code is quite ugly, and this doesn't >>> improve things. But it doesn't make it significantly wor

Re: [U-Boot] [PATCH v1 02/15] fs/fat: implement readdir

2017-08-12 Thread Rob Clark
On Sat, Aug 12, 2017 at 8:17 AM, Alexander Graf wrote: > > > On 10.08.17 20:29, Rob Clark wrote: >> >> Yes, this is super-hacky. The FAT code is quite ugly, and this doesn't >> improve things. But it doesn't make it significantly worse either. The >> better option would be a massive FAT re-writ

Re: [U-Boot] [PATCH v1 02/15] fs/fat: implement readdir

2017-08-12 Thread Alexander Graf
On 10.08.17 20:29, Rob Clark wrote: Yes, this is super-hacky. The FAT code is quite ugly, and this doesn't improve things. But it doesn't make it significantly worse either. The better option would be a massive FAT re-write to get rid of the hacky way that fat_file_ls() works. Volunteers we

[U-Boot] [PATCH v1 02/15] fs/fat: implement readdir

2017-08-10 Thread Rob Clark
Yes, this is super-hacky. The FAT code is quite ugly, and this doesn't improve things. But it doesn't make it significantly worse either. The better option would be a massive FAT re-write to get rid of the hacky way that fat_file_ls() works. Volunteers welcome. Signed-off-by: Rob Clark --- f