Re: [U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Fabio Estevam
On Tue, Sep 30, 2014 at 2:43 PM, Stefano Babic wrote: > ok - I have seen V3, I will apply it. Thanks, Stefano! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Stefano Babic
Hi Fabio, On 30/09/2014 18:31, Fabio Estevam wrote: > Hi Stefano, > > On Tue, Sep 30, 2014 at 1:08 PM, Stefano Babic wrote: > >> I do not like this approach because we do not need an additional >> CONFIG_, that remains undocumented. If CONFIG_MX6SX, HAB_RVT_BASE is >> always 0x100 - CONFIG_ROM_

Re: [U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Fabio Estevam
Hi Stefano, On Tue, Sep 30, 2014 at 1:08 PM, Stefano Babic wrote: > I do not like this approach because we do not need an additional > CONFIG_, that remains undocumented. If CONFIG_MX6SX, HAB_RVT_BASE is > always 0x100 - CONFIG_ROM_UNIFIED_SECTIONS is like a redundant > information, because it i

Re: [U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Stefano Babic
Hi Nitin, hi Fabio, thanks for immediately fix the issue - I have some comments. On 30/09/2014 17:40, Nitin Garg wrote: > i.MX6SX ROM implements unified table sections. > The HAB function table is at offset 0x100. Update > the HAB function pointers accordingly. > > Signed-off-by: Nitin Garg > T

Re: [U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Fabio Estevam
On Tue, Sep 30, 2014 at 12:40 PM, Nitin Garg wrote: > i.MX6SX ROM implements unified table sections. > The HAB function table is at offset 0x100. Update > the HAB function pointers accordingly. > > Signed-off-by: Nitin Garg > Tested-by: Fabio Estevam You should have marked this patch as v2 and

[U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Nitin Garg
i.MX6SX ROM implements unified table sections. The HAB function table is at offset 0x100. Update the HAB function pointers accordingly. Signed-off-by: Nitin Garg Tested-by: Fabio Estevam --- arch/arm/include/asm/arch-mx6/hab.h | 16 +++- include/configs/mx6_common.h|

Re: [U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Fabio Estevam
On Tue, Sep 30, 2014 at 11:43 AM, Nitin Garg wrote: > i.MX6SX ROM implements unified table sections. > The HAB function table is at offset 0x100. Update > the HAB function pointers accordingly. > > Signed-off-by: Nitin Garg It fixes the issue for me, thanks. I have one comment though. > --- a/i

[U-Boot] [PATCH v1] imx6sx: Fix i.MX6SX HAB api function table offset

2014-09-30 Thread Nitin Garg
i.MX6SX ROM implements unified table sections. The HAB function table is at offset 0x100. Update the HAB function pointers accordingly. Signed-off-by: Nitin Garg --- arch/arm/include/asm/arch-mx6/hab.h | 33 +++-- include/configs/mx6sxsabresd.h |1 + 2 fi