Re: [U-Boot] [PATCH v1] env: fix crash using default -f -a

2012-10-05 Thread Stefano Babic
On 05/10/2012 12:58, Gerlando Falauto wrote: > My idea here was to "apply" the changes as soon as the environment gets > changed, like it would happen with a manual "setenv"/"env set". > So for instance, if you switch from a custom baudrate back to the > default baudrate, you get a message prompti

Re: [U-Boot] [PATCH v1] env: fix crash using default -f -a

2012-10-05 Thread Gerlando Falauto
Hi Stefano, On 10/05/2012 12:41 PM, Stefano Babic wrote: On 05/10/2012 12:29, Gerlando Falauto wrote: Hi Stefano, Hi Gerlando, thanks for reporting and providing a fix for this. I'm very sorry for introducing this problem and for the late response. Please see my comments below. [As a sid

Re: [U-Boot] [PATCH v1] env: fix crash using default -f -a

2012-10-05 Thread Stefano Babic
On 05/10/2012 12:29, Gerlando Falauto wrote: > Hi Stefano, > Hi Gerlando, > thanks for reporting and providing a fix for this. > I'm very sorry for introducing this problem and for the late response. > > Please see my comments below. > > [As a side node, I couldn't really reproduce the issue n

Re: [U-Boot] [PATCH v1] env: fix crash using default -f -a

2012-10-05 Thread Gerlando Falauto
Hi Stefano, thanks for reporting and providing a fix for this. I'm very sorry for introducing this problem and for the late response. Please see my comments below. [As a side node, I couldn't really reproduce the issue neither on PowerPC nor on ARM (though simple_strtoul should legitimately cr

Re: [U-Boot] [PATCH v1] env: fix crash using default -f -a

2012-10-04 Thread Tom Rini
On Thu, Oct 04, 2012 at 07:30:43PM +0200, Stefano Babic wrote: > newval pointer is not checked before its usage, > inside env_check_apply(). > > Signed-off-by: Stefano Babic > CC: gerlando.fala...@keymile.com Some egg on my face for not catching this to start with, confirmed problem and fix her

[U-Boot] [PATCH v1] env: fix crash using default -f -a

2012-10-04 Thread Stefano Babic
newval pointer is not checked before its usage, inside env_check_apply(). Signed-off-by: Stefano Babic CC: gerlando.fala...@keymile.com --- common/cmd_nvedit.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 3474bc6..81