Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-27 Thread Stefano Babic
On 27/01/2012 10:07, Govindraj wrote: >> >> My only concern is that I would really like to wait for the cleanup / >> fixup series to be complete before we pull this change in as well. >> > > Yes thanks, > > I am working on some comments from Igor to make use of ulpi frame work > for soft phy res

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-27 Thread Govindraj
On Thu, Jan 26, 2012 at 2:19 AM, Tom Rini wrote: > On Wed, Jan 25, 2012 at 3:32 AM, Stefano Babic wrote: >> On 17/01/2012 07:14, Govindraj wrote: >>> On Mon, Jan 16, 2012 at 3:27 PM, Stefano Babic wrote: On 16/01/2012 08:58, Govindraj wrote: > Th v2 patch series [1] posted is based

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-25 Thread Tom Rini
On Wed, Jan 25, 2012 at 3:32 AM, Stefano Babic wrote: > On 17/01/2012 07:14, Govindraj wrote: >> On Mon, Jan 16, 2012 at 3:27 PM, Stefano Babic wrote: >>> On 16/01/2012 08:58, Govindraj wrote: >>> Th v2 patch series [1] posted is based on top of this patch. >>> >>> If I understand well, we n

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-25 Thread Stefano Babic
On 17/01/2012 07:14, Govindraj wrote: > On Mon, Jan 16, 2012 at 3:27 PM, Stefano Babic wrote: >> On 16/01/2012 08:58, Govindraj wrote: >> >>> Th v2 patch series [1] posted is based on top of this patch. >> >> If I understand well, we need in any case Ilya's patch. In this case, it >> is maybe wort

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-16 Thread Govindraj
On Mon, Jan 16, 2012 at 3:27 PM, Stefano Babic wrote: > On 16/01/2012 08:58, Govindraj wrote: > >> Th v2 patch series [1] posted is based on top of this patch. > > If I understand well, we need in any case Ilya's patch. In this case, it > is maybe worth to merge Ilya's patch in the meanwhile (and

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-16 Thread Stefano Babic
On 16/01/2012 08:58, Govindraj wrote: > Th v2 patch series [1] posted is based on top of this patch. If I understand well, we need in any case Ilya's patch. In this case, it is maybe worth to merge Ilya's patch in the meanwhile (and please drop my patch that remove USB support from TAM3517 boards

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-15 Thread Govindraj
On Mon, Jan 16, 2012 at 3:34 AM, Tom Rini wrote: > On Sun, Jan 15, 2012 at 1:40 PM, Remy Bohmer wrote: >> Hi All, >> >> 2011/12/22 Ilya Yanok : >>> Hi Govindraj, >>> >>> On 22.12.2011 10:55, Govindraj wrote: > > Signed-off-by: Ilya Yanok > --- > Changes from V3: >  - None >>>

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-15 Thread Tom Rini
On Sun, Jan 15, 2012 at 1:40 PM, Remy Bohmer wrote: > Hi All, > > 2011/12/22 Ilya Yanok : >> Hi Govindraj, >> >> On 22.12.2011 10:55, Govindraj wrote: Signed-off-by: Ilya Yanok --- Changes from V3:  - None Changes from V2:  - None Changes from V1:  - C

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2012-01-15 Thread Remy Bohmer
Hi All, 2011/12/22 Ilya Yanok : > Hi Govindraj, > > On 22.12.2011 10:55, Govindraj wrote: >>> >>> Signed-off-by: Ilya Yanok >>> --- >>> Changes from V3: >>>  - None >>> Changes from V2: >>>  - None >>> Changes from V1: >>>  - CONFIG_OMAP_EHCI_PHYx_RESET changed to CONFIG_OMAP_EHCI_PHYx_RESET_GPIO

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Ilya Yanok
Hi Govindraj, On 22.12.2011 10:55, Govindraj wrote: >> >> Signed-off-by: Ilya Yanok >> --- >> Changes from V3: >> - None >> Changes from V2: >> - None >> Changes from V1: >> - CONFIG_OMAP_EHCI_PHYx_RESET changed to CONFIG_OMAP_EHCI_PHYx_RESET_GPIO >> - phy reset moved to separate function >>

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Govindraj
On Thu, Dec 22, 2011 at 4:48 PM, Igor Grinberg wrote: > On 12/22/11 12:49, Govindraj wrote: >> On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg >> wrote: >>> On 12/22/11 11:26, Govindraj wrote: Hi Igor, >> >> [...] >> probably the right method to do is as we did for panda,

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Igor Grinberg
On 12/22/11 12:49, Govindraj wrote: > On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg > wrote: >> On 12/22/11 11:26, Govindraj wrote: >>> Hi Igor, >>> > > [...] > >>> >>> probably the right method to do is as we did for panda, >>> >>> Add to armv7/omap3/clock.c (soc specific code) to enable usb-

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Govindraj
On Thu, Dec 22, 2011 at 3:29 PM, Igor Grinberg wrote: > On 12/22/11 11:26, Govindraj wrote: >> Hi Igor, >> [...] >> >> probably the right method to do is as we did for panda, >> >> Add to armv7/omap3/clock.c (soc specific code) to enable usb-host clocks. >> >> as done in below patch for omap4 so

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Igor Grinberg
On 12/22/11 11:26, Govindraj wrote: > Hi Igor, > > On Thu, Dec 22, 2011 at 1:44 PM, Igor Grinberg > wrote: >> Hi Govindraj, >> >> On 12/22/11 08:55, Govindraj wrote: >>> Hi IIya Yanok, [...] >>> On Tue, Dec 13, 2011 at 4:45 AM, Ilya Yanok wrote: Taken from Beagle code. Tested on mcx boar

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Govindraj
Hi Igor, On Thu, Dec 22, 2011 at 1:44 PM, Igor Grinberg wrote: > Hi Govindraj, > > On 12/22/11 08:55, Govindraj wrote: >> Hi IIya Yanok, >> >> Sorry for late comments. > > Better late than never... > >> >> On Tue, Dec 13, 2011 at 4:45 AM, Ilya Yanok wrote: >>> Taken from Beagle code. Tested on m

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-22 Thread Igor Grinberg
Hi Govindraj, On 12/22/11 08:55, Govindraj wrote: > Hi IIya Yanok, > > Sorry for late comments. Better late than never... > > On Tue, Dec 13, 2011 at 4:45 AM, Ilya Yanok wrote: >> Taken from Beagle code. Tested on mcx board (AM3517-based). >> >> Signed-off-by: Ilya Yanok >> --- >> Changes fr

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-21 Thread Govindraj
Hi IIya Yanok, Sorry for late comments. On Tue, Dec 13, 2011 at 4:45 AM, Ilya Yanok wrote: > Taken from Beagle code. Tested on mcx board (AM3517-based). > > Signed-off-by: Ilya Yanok > --- > Changes from V3: >  - None > Changes from V2: >  - None > Changes from V1: >  - CONFIG_OMAP_EHCI_PHYx_RE

Re: [U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-19 Thread Ilya Yanok
Hi Remy, could you please review this patch? It's waiting for your approval. Regards, Ilya. On 13.12.2011 03:15, Ilya Yanok wrote: > Taken from Beagle code. Tested on mcx board (AM3517-based). > > Signed-off-by: Ilya Yanok > --- > Changes from V3: > - None > Changes from V2: > - None > Chang

[U-Boot] [PATCH V4 1/2] ehci-omap: driver for EHCI host on OMAP3

2011-12-12 Thread Ilya Yanok
Taken from Beagle code. Tested on mcx board (AM3517-based). Signed-off-by: Ilya Yanok --- Changes from V3: - None Changes from V2: - None Changes from V1: - CONFIG_OMAP_EHCI_PHYx_RESET changed to CONFIG_OMAP_EHCI_PHYx_RESET_GPIO - phy reset moved to separate function - Calls to gpio_set_valu