Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-29 Thread Graeme Russ
Hi Vladim On Fri, Sep 30, 2011 at 9:39 AM, Vadim Bendebury wrote: > On Thu, Sep 29, 2011 at 4:15 PM, Graeme Russ wrote: >> Hi Vadim, >> >> On Wed, Sep 28, 2011 at 12:55 AM, Vadim Bendebury >> wrote: >>> On Tue, Sep 27, 2011 at 4:22 AM, Graeme Russ wrote: Hi Vadim, On 27/09/11 0

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-29 Thread Vadim Bendebury
On Thu, Sep 29, 2011 at 4:15 PM, Graeme Russ wrote: > Hi Vadim, > > On Wed, Sep 28, 2011 at 12:55 AM, Vadim Bendebury > wrote: >> On Tue, Sep 27, 2011 at 4:22 AM, Graeme Russ wrote: >>> Hi Vadim, >>> >>> On 27/09/11 08:50, Vadim Bendebury wrote: On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-29 Thread Graeme Russ
Hi Vadim, On Wed, Sep 28, 2011 at 12:55 AM, Vadim Bendebury wrote: > On Tue, Sep 27, 2011 at 4:22 AM, Graeme Russ wrote: >> Hi Vadim, >> >> On 27/09/11 08:50, Vadim Bendebury wrote: >>> On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote: [snip] >> Typically, the pre-console buffer would exist

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-27 Thread Vadim Bendebury
On Tue, Sep 27, 2011 at 4:22 AM, Graeme Russ wrote: > Hi Vadim, > > On 27/09/11 08:50, Vadim Bendebury wrote: >> On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote: >>> Allow redirection of console output prior to console initialisation to a >>> temporary buffer. >>> >>> To enable this functional

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-27 Thread Graeme Russ
Hi Vadim, On 27/09/11 08:50, Vadim Bendebury wrote: > On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote: >> Allow redirection of console output prior to console initialisation to a >> temporary buffer. >> >> To enable this functionality, the board configuration file must define: >> - CONFIG_PRE

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-09-26 Thread Vadim Bendebury
On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote: > Allow redirection of console output prior to console initialisation to a > temporary buffer. > > To enable this functionality, the board configuration file must define: >  - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer >  - CONFIG_PRE_

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Graeme Russ
Hi Mike, On Thu, Sep 1, 2011 at 8:44 AM, Mike Frysinger wrote: > On Wednesday, August 31, 2011 17:59:19 Graeme Russ wrote: >> So it applies? > > yep.  and even compiles without warnings. Ah, but does it work ;) Regards, Graeme ___ U-Boot mailing list

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Mike Frysinger
On Wednesday, August 31, 2011 17:59:19 Graeme Russ wrote: > So it applies? yep. and even compiles without warnings. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.den

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Graeme Russ
Hi Mike On Thursday, September 1, 2011, Mike Frysinger wrote: > On Wednesday, August 31, 2011 17:15:25 Graeme Russ wrote: >> On 01/09/11 01:09, Mike Frysinger wrote: >> > On Wednesday, August 31, 2011 08:58:25 Graeme Russ wrote: >> >> Allow redirection of console output prior to console initialis

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Mike Frysinger
On Wednesday, August 31, 2011 17:15:25 Graeme Russ wrote: > On 01/09/11 01:09, Mike Frysinger wrote: > > On Wednesday, August 31, 2011 08:58:25 Graeme Russ wrote: > >> Allow redirection of console output prior to console initialisation to a > >> temporary buffer. > > > > looks good to me. doesnt

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Graeme Russ
Hi Mike, On 01/09/11 01:09, Mike Frysinger wrote: > On Wednesday, August 31, 2011 08:58:25 Graeme Russ wrote: >> Allow redirection of console output prior to console initialisation to a >> temporary buffer. > > looks good to me. doesnt apply, but that's because this needs your other gd > rework

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Simon Glass
On Wed, Aug 31, 2011 at 1:22 PM, Mike Frysinger wrote: > On Wednesday, August 31, 2011 16:05:38 Simon Glass wrote: >> On Wed, Aug 31, 2011 at 12:18 PM, Wolfgang Denk wrote: >> > Simon Glass wrote: >> >> nit: circular. Just a suggestion if you like: you could also offer >> >> guidance for the locat

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Mike Frysinger
On Wednesday, August 31, 2011 16:05:38 Simon Glass wrote: > On Wed, Aug 31, 2011 at 12:18 PM, Wolfgang Denk wrote: > > Simon Glass wrote: > >> nit: circular. Just a suggestion if you like: you could also offer > >> guidance for the location of the buffer, something like: > >> > >> You can place th

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Simon Glass
Hi Wolfgang, On Wed, Aug 31, 2011 at 12:18 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> nit: circular. Just a suggestion if you like: you could also offer >> guidance for the location of the buffer, something like: >> >> You can place the buffer at the top o

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > nit: circular. Just a suggestion if you like: you could also offer > guidance for the location of the buffer, something like: > > You can place the buffer at the top of memory by adding something like > this in your board config file: > > #define CONF

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Simon Glass
Hi Graeme, On Wed, Aug 31, 2011 at 5:58 AM, Graeme Russ wrote: > Allow redirection of console output prior to console initialisation to a > temporary buffer. > > To enable this functionality, the board configuration file must define: >  - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer >  -

Re: [U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Mike Frysinger
On Wednesday, August 31, 2011 08:58:25 Graeme Russ wrote: > Allow redirection of console output prior to console initialisation to a > temporary buffer. looks good to me. doesnt apply, but that's because this needs your other gd rework patch. Acked-by: Mike Frysinger -mike signature.asc Desc

[U-Boot] [PATCH V4] console: Implement pre-console buffer

2011-08-31 Thread Graeme Russ
Allow redirection of console output prior to console initialisation to a temporary buffer. To enable this functionality, the board configuration file must define: - CONFIG_PRE_CONSOLE_BUFFER - Enable pre-console buffer - CONFIG_PRE_CON_BUF_ADDR - Base address of pre-console buffer - CONFIG_PRE_