Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Thursday, September 15, 2011 04:26:17 AM Jason Hui wrote: > On Thu, Sep 15, 2011 at 10:07 AM, Marek Vasut wrote: > > On Thursday, September 15, 2011 03:43:42 AM Jason Hui wrote: > >> On Thu, Sep 15, 2011 at 3:39 AM, Marek Vasut wrote: > >> > On Friday, July 29, 2011 08:55:14 AM Jason Hui wrote

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Thu, Sep 15, 2011 at 10:07 AM, Marek Vasut wrote: > On Thursday, September 15, 2011 03:43:42 AM Jason Hui wrote: >> On Thu, Sep 15, 2011 at 3:39 AM, Marek Vasut wrote: >> > On Friday, July 29, 2011 08:55:14 AM Jason Hui wrote: >> >> Hi, Marek, >> >> >> >> On Thu, Jul 14, 2011 at 5:58 AM, Marek

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Thursday, September 15, 2011 03:43:42 AM Jason Hui wrote: > On Thu, Sep 15, 2011 at 3:39 AM, Marek Vasut wrote: > > On Friday, July 29, 2011 08:55:14 AM Jason Hui wrote: > >> Hi, Marek, > >> > >> On Thu, Jul 14, 2011 at 5:58 AM, Marek Vasut wrote: > >> > Rewrite the mxc_i2c driver. > >> > *

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Thu, Sep 15, 2011 at 3:39 AM, Marek Vasut wrote: > On Friday, July 29, 2011 08:55:14 AM Jason Hui wrote: >> Hi, Marek, >> >> On Thu, Jul 14, 2011 at 5:58 AM, Marek Vasut wrote: >> > Rewrite the mxc_i2c driver. >> >  * This version is much closer to Linux implementation. >> >  * Fixes IPG_PERCL

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Friday, July 29, 2011 08:55:14 AM Jason Hui wrote: > Hi, Marek, > > On Thu, Jul 14, 2011 at 5:58 AM, Marek Vasut wrote: > > Rewrite the mxc_i2c driver. > > * This version is much closer to Linux implementation. > > * Fixes IPG_PERCLK being incorrectly used as clock source > > * Fixes behavi

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On 07/13/2011 11:58 PM, Marek Vasut wrote: > Rewrite the mxc_i2c driver. > * This version is much closer to Linux implementation. > * Fixes IPG_PERCLK being incorrectly used as clock source > * Fixes behaviour of the driver on iMX51 > * Clean up coding style a bit ;-) Hi Marek, as it seems we

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On 07/29/2011 11:35 AM, Marek Vasut wrote: >> >> why you change i2c clock from IPG_PERCLK to IPG_CLK? > > On MX51, PERCLK are those fast (680MHz) clock, that's not source of clock for > I2C. The IPG_CLK (they are 68.5MHz iirc) are source for the I2C. Also, I > discussed this with Stefano and we

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Friday, July 29, 2011 08:55:14 AM Jason Hui wrote: > Hi, Marek, > > On Thu, Jul 14, 2011 at 5:58 AM, Marek Vasut wrote: > > Rewrite the mxc_i2c driver. > > * This version is much closer to Linux implementation. > > * Fixes IPG_PERCLK being incorrectly used as clock source > > * Fixes behavi

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

Hi, Marek, On Thu, Jul 14, 2011 at 5:58 AM, Marek Vasut wrote: > Rewrite the mxc_i2c driver. >  * This version is much closer to Linux implementation. >  * Fixes IPG_PERCLK being incorrectly used as clock source >  * Fixes behaviour of the driver on iMX51 >  * Clean up coding style a bit ;-) > w

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

Dear Marek, In message <4e1eb127.3040...@denx.de> Heiko wrote: > Hello Marek, > > Marek Vasut wrote: > > Rewrite the mxc_i2c driver. > > * This version is much closer to Linux implementation. > > * Fixes IPG_PERCLK being incorrectly used as clock source > > * Fixes behaviour of the driver on i

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

Hi again Marek, Le 14/07/2011 16:35, Marek Vasut a écrit : > On Thursday, July 14, 2011 03:55:03 PM Albert ARIBAUD wrote: >> Hi Marek, >> >> Le 13/07/2011 23:58, Marek Vasut a écrit : >>> V3+: Add commit ID into commit message >> >> What prevents a simple V4 here? > > No change in code ... but I s

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

On Thursday, July 14, 2011 03:55:03 PM Albert ARIBAUD wrote: > Hi Marek, > > Le 13/07/2011 23:58, Marek Vasut a écrit : > > V3+: Add commit ID into commit message > > What prevents a simple V4 here? No change in code ... but I suspect there'll be V4 anyway. > > Amicalement,

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

Hi Marek, Le 13/07/2011 23:58, Marek Vasut a écrit : > V3+: Add commit ID into commit message What prevents a simple V4 here? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH V3+] I2C: mxc_i2c rework

Hello Marek, Marek Vasut wrote: > Rewrite the mxc_i2c driver. > * This version is much closer to Linux implementation. > * Fixes IPG_PERCLK being incorrectly used as clock source > * Fixes behaviour of the driver on iMX51 > * Clean up coding style a bit ;-) > > Based on commit: e39428d53d080a

[U-Boot] [PATCH V3+] I2C: mxc_i2c rework

Rewrite the mxc_i2c driver. * This version is much closer to Linux implementation. * Fixes IPG_PERCLK being incorrectly used as clock source * Fixes behaviour of the driver on iMX51 * Clean up coding style a bit ;-) Based on commit: e39428d53d080ad2615b772d7f99d2a70c2aaab2 Date: Mon Jun 21 0

Re: [U-Boot] [PATCH V3] I2C: mxc_i2c rework

Dear Marek Vasut, In message <1310591152-3791-1-git-send-email-marek.va...@gmail.com> you wrote: > Rewrite the mxc_i2c driver. > * This version is much closer to Linux implementation. > * Fixes IPG_PERCLK being incorrectly used as clock source > * Fixes behaviour of the driver on iMX51 > * Cle

[U-Boot] [PATCH V3] I2C: mxc_i2c rework

Rewrite the mxc_i2c driver. * This version is much closer to Linux implementation. * Fixes IPG_PERCLK being incorrectly used as clock source * Fixes behaviour of the driver on iMX51 * Clean up coding style a bit ;-) Signed-off-by: Marek Vasut --- drivers/i2c/mxc_i2c.c | 424