Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-07-20 Thread Stefano Babic
On 20/07/2012 07:35, Dirk Behme wrote: > Then > > http://lists.denx.de/pipermail/u-boot/2012-June/126097.html > > mentions "WD applied the cache stub patch already". > > So do we have this "cache stub patch" somewhere which fixes the issue > mentioned above? I'm not sure I've seen it ... It is

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-07-19 Thread Dirk Behme
On 20.07.2012 04:32, Marek Vasut wrote: Dear Dirk Behme, [...] I'm not likely to have any time until after FTF next week. Any chance that a PPC maintainer can chime in here? I think WD applied the cache stub patch already. Can you try now please? Ping ;) Thanks Dirk I just noticed this

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-07-19 Thread Marek Vasut
Dear Dirk Behme, [...] > >> I'm not likely to have any time until after FTF next week. > >> > >> Any chance that a PPC maintainer can chime in here? > > > > I think WD applied the cache stub patch already. Can you try now please? > > Ping ;) > > Thanks > > Dirk I just noticed this with late

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-07-13 Thread Marek Vasut
Dear Dirk Behme, [...] > >> I'm not likely to have any time until after FTF next week. > >> > >> Any chance that a PPC maintainer can chime in here? > > > > I think WD applied the cache stub patch already. Can you try now please? > > Ping ;) > > Thanks Adding our human interactions expert in

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-07-10 Thread Dirk Behme
On 12.06.2012 19:23, Marek Vasut wrote: Dear Eric Nelson, On 06/12/2012 10:07 AM, Stefano Babic wrote: On 15/05/2012 14:58, Dirk Behme wrote: On 09.05.2012 07:45, Stefano Babic wrote: On 09/05/2012 01:31, Eric Nelson wrote: Thanks Andy, On 05/08/2012 03:59 PM, Andy Fleming wrote: --- a/dr

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-06-12 Thread Marek Vasut
Dear Eric Nelson, > On 06/12/2012 10:07 AM, Stefano Babic wrote: > > On 15/05/2012 14:58, Dirk Behme wrote: > >> On 09.05.2012 07:45, Stefano Babic wrote: > >>> On 09/05/2012 01:31, Eric Nelson wrote: > Thanks Andy, > > On 05/08/2012 03:59 PM, Andy Fleming wrote: > >> --- a/dri

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-06-12 Thread Eric Nelson
On 06/12/2012 10:07 AM, Stefano Babic wrote: On 15/05/2012 14:58, Dirk Behme wrote: On 09.05.2012 07:45, Stefano Babic wrote: On 09/05/2012 01:31, Eric Nelson wrote: Thanks Andy, On 05/08/2012 03:59 PM, Andy Fleming wrote: --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -190,6

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-06-12 Thread Stefano Babic
On 15/05/2012 14:58, Dirk Behme wrote: > On 09.05.2012 07:45, Stefano Babic wrote: >> On 09/05/2012 01:31, Eric Nelson wrote: >>> Thanks Andy, >>> >>> On 05/08/2012 03:59 PM, Andy Fleming wrote: > --- a/drivers/mmc/fsl_esdhc.c > +++ b/drivers/mmc/fsl_esdhc.c > @@ -190,6 +190,10 @@ stati

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-15 Thread Marek Vasut
Dear Eric Nelson, > On 05/15/2012 06:09 AM, Anatolij Gustschin wrote: > > Hi Dirk, > > > > On Tue, 15 May 2012 14:58:54 +0200 > > > > Dirk Behme wrote: > >> On 09.05.2012 07:45, Stefano Babic wrote: > > ... > > > >>> The problem with an #ifdef is that it is not very generic - we should > >>> a

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-15 Thread Eric Nelson
On 05/15/2012 06:09 AM, Anatolij Gustschin wrote: Hi Dirk, On Tue, 15 May 2012 14:58:54 +0200 Dirk Behme wrote: On 09.05.2012 07:45, Stefano Babic wrote: ... The problem with an #ifdef is that it is not very generic - we should add some #if (defined(CONFIG_MX51) || defined(CONFIG_MX53) || .

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-15 Thread Anatolij Gustschin
Hi Dirk, On Tue, 15 May 2012 14:58:54 +0200 Dirk Behme wrote: > On 09.05.2012 07:45, Stefano Babic wrote: ... > > The problem with an #ifdef is that it is not very generic - we should > > add some #if (defined(CONFIG_MX51) || defined(CONFIG_MX53) || ... > > and update the driver for each new SOC

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-15 Thread Dirk Behme
On 09.05.2012 07:45, Stefano Babic wrote: On 09/05/2012 01:31, Eric Nelson wrote: Thanks Andy, On 05/08/2012 03:59 PM, Andy Fleming wrote: --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -190,6 +190,10 @@ static int esdhc_setup_data(struct mmc *mmc, struct mmc_data *data)

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-08 Thread Stefano Babic
On 09/05/2012 01:31, Eric Nelson wrote: > Thanks Andy, > > On 05/08/2012 03:59 PM, Andy Fleming wrote: >>> --- a/drivers/mmc/fsl_esdhc.c >>> +++ b/drivers/mmc/fsl_esdhc.c >>> @@ -190,6 +190,10 @@ static int esdhc_setup_data(struct mmc *mmc, >>> struct mmc_data *data) >>> esdhc_clrs

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-08 Thread Eric Nelson
Thanks Andy, On 05/08/2012 03:59 PM, Andy Fleming wrote: --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -190,6 +190,10 @@ static int esdhc_setup_data(struct mmc *mmc, struct mmc_data *data) esdhc_clrsetbits32(®s->wml, WML_RD_WML_MASK, wml_value);

Re: [U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-05-08 Thread Andy Fleming
> --- a/drivers/mmc/fsl_esdhc.c > +++ b/drivers/mmc/fsl_esdhc.c > @@ -190,6 +190,10 @@ static int esdhc_setup_data(struct mmc *mmc, struct > mmc_data *data) >                esdhc_clrsetbits32(®s->wml, WML_RD_WML_MASK, wml_value); >                esdhc_write32(®s->dsaddr, (u32)data->dest); >    

[U-Boot] [PATCH V2] i.MX: fsl_esdhc: allow use with cache enabled.

2012-04-25 Thread Eric Nelson
Signed-off-by: Eric Nelson --- V2 fixes checkpatch errors and typecasts as pointed out on the ML. drivers/mmc/fsl_esdhc.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index a2f35e3..539d848 100644 ---