Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-06-12 Thread Pantelis Antoniou
Hi Stephen, On May 23, 2014, at 9:59 PM, Stephen Warren wrote: > On 05/20/2014 10:57 AM, Stephen Warren wrote: >> From: Bryan Wu >> >> mmc dev ${devnum} will return 0 as success even if there is no card >> inserted. Booting script like tegra-common-post.h will call mmc dev >> ${devnum} to check

Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-23 Thread Stephen Warren
On 05/20/2014 10:57 AM, Stephen Warren wrote: > From: Bryan Wu > > mmc dev ${devnum} will return 0 as success even if there is no card > inserted. Booting script like tegra-common-post.h will call mmc dev > ${devnum} to check the mmc device status, it always return 0 even if > mmc_init() fails. >

Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-22 Thread Stephen Warren
On 05/21/2014 07:41 PM, Jaehoon Chung wrote: > On 05/22/2014 01:18 AM, Stephen Warren wrote: >> On 05/20/2014 11:40 PM, Jaehoon Chung wrote: >>> Hi, Stephen. >>> >>> i didn't apply your patch. Which repository do you use? >> >> It's based on u-boot.git master branch. The latest u-boot-mmc.git maste

Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-21 Thread Jaehoon Chung
On 05/22/2014 01:18 AM, Stephen Warren wrote: > On 05/20/2014 11:40 PM, Jaehoon Chung wrote: >> Hi, Stephen. >> >> i didn't apply your patch. Which repository do you use? > > It's based on u-boot.git master branch. The latest u-boot-mmc.git master > branch is already included in that branch, and i

Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-21 Thread Stephen Warren
On 05/20/2014 11:40 PM, Jaehoon Chung wrote: > Hi, Stephen. > > i didn't apply your patch. Which repository do you use? It's based on u-boot.git master branch. The latest u-boot-mmc.git master branch is already included in that branch, and it looks like some changes have been applied to cmd_mmc.c

Re: [U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-20 Thread Jaehoon Chung
Hi, Stephen. i didn't apply your patch. Which repository do you use? Well, if you want to check, can be used "if (mmc_init(mmc))". And i'm not sure whether this code is really need or not. Best Regards, Jaehoon Chung On 05/21/2014 01:57 AM, Stephen Warren wrote: > From: Bryan Wu > > mmc dev $

[U-Boot] [PATCH V2] cmd_mmc.c: check mmc_init() during mmc dev

2014-05-20 Thread Stephen Warren
From: Bryan Wu mmc dev ${devnum} will return 0 as success even if there is no card inserted. Booting script like tegra-common-post.h will call mmc dev ${devnum} to check the mmc device status, it always return 0 even if mmc_init() fails. Check mmc_init() return value let mmc dev command return f