Re: [U-Boot] [PATCH V2] arm/board.c: avoid ifdef using weak default functions

2009-11-27 Thread Joakim Tjernlund
Tom wrote on 26/11/2009 20:18:22: > > Joakim Tjernlund wrote: > >> From: Alessandro Rubini > >> > >> While it's a matter of personal taste, I prefer to avoid ifdef when > >> possible. For example, I don't like to add BOARD_LATE_INIT in the > >> config file just to add a board_late_init() functio

Re: [U-Boot] [PATCH V2] arm/board.c: avoid ifdef using weak default functions

2009-11-26 Thread Tom
Joakim Tjernlund wrote: >> From: Alessandro Rubini >> >> While it's a matter of personal taste, I prefer to avoid ifdef when >> possible. For example, I don't like to add BOARD_LATE_INIT in the >> config file just to add a board_late_init() function. >> Also, I think the file is more readable wit

Re: [U-Boot] [PATCH V2] arm/board.c: avoid ifdef using weak default functions

2009-11-26 Thread Tom
Alessandro Rubini wrote: > From: Alessandro Rubini > > While it's a matter of personal taste, I prefer to avoid ifdef when > possible. For example, I don't like to add BOARD_LATE_INIT in the > config file just to add a board_late_init() function. > Also, I think the file is more readable without

Re: [U-Boot] [PATCH V2] arm/board.c: avoid ifdef using weak default functions

2009-11-26 Thread Joakim Tjernlund
> > From: Alessandro Rubini > > While it's a matter of personal taste, I prefer to avoid ifdef when > possible. For example, I don't like to add BOARD_LATE_INIT in the > config file just to add a board_late_init() function. > Also, I think the file is more readable without the ifdef stuff. > This

[U-Boot] [PATCH V2] arm/board.c: avoid ifdef using weak default functions

2009-11-26 Thread Alessandro Rubini
From: Alessandro Rubini While it's a matter of personal taste, I prefer to avoid ifdef when possible. For example, I don't like to add BOARD_LATE_INIT in the config file just to add a board_late_init() function. Also, I think the file is more readable without the ifdef stuff. This uses two trivi