Re: [U-Boot] [PATCH RFC 1/3] arm920t: do not set register useless

2010-11-30 Thread Albert ARIBAUD
Le 30/11/2010 09:28, Andreas Bießmann a écrit : >>> +beqclear_bss/* skip relocation */ >>> +movr1, r6 >> >> Why use r1? > > Use a scratch register here cause stmia Rn! does increment Rn. > Therefore usage of r6 here would destroy the saved 'addr of > destination'. Cause th

Re: [U-Boot] [PATCH RFC 1/3] arm920t: do not set register useless

2010-11-30 Thread Andreas Bießmann
Dear Albert ARIBAUD, Am 30.11.2010 09:07, schrieb Albert ARIBAUD: > Hi Andreas, > > Le 30/11/2010 08:06, Andreas Bießmann a écrit : > >> diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S >> index 01edb9b..71de373 100644 >> --- a/arch/arm/cpu/arm920t/start.S >> +++ b/arch/a

Re: [U-Boot] [PATCH RFC 1/3] arm920t: do not set register useless

2010-11-30 Thread Albert ARIBAUD
Hi Andreas, Le 30/11/2010 08:06, Andreas Bießmann a écrit : > diff --git a/arch/arm/cpu/arm920t/start.S b/arch/arm/cpu/arm920t/start.S > index 01edb9b..71de373 100644 > --- a/arch/arm/cpu/arm920t/start.S > +++ b/arch/arm/cpu/arm920t/start.S > @@ -208,15 +208,16 @@ stack_setup: > mov sp,

[U-Boot] [PATCH RFC 1/3] arm920t: do not set register useless

2010-11-29 Thread Andreas Bießmann
in case we are still at relocation target address before relocation we do not need to load the registers needed for relocation. We should instead skip the whole relocation part and jump over to clear_bss. Also prepare to not use target address twice. When we use a scratch register here r6 is uncha