Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-15 Thread Michael Trimarchi
Hi On Sun, Sep 15, 2013 at 5:20 PM, Albert ARIBAUD wrote: > Hi Michael, > > On Sat, 14 Sep 2013 11:38:02 +0200, Michael Trimarchi > wrote: > >> Hi Axel >> >> On Sat, Sep 14, 2013 at 11:34 AM, Axel Lin wrote: >> > 2013/9/14 Albert ARIBAUD : >> >> Hi Axel, >> >> >> >> On Fri, 06 Sep 2013 14:22:40

Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-15 Thread Albert ARIBAUD
Hi Michael, On Sat, 14 Sep 2013 11:38:02 +0200, Michael Trimarchi wrote: > Hi Axel > > On Sat, Sep 14, 2013 at 11:34 AM, Axel Lin wrote: > > 2013/9/14 Albert ARIBAUD : > >> Hi Axel, > >> > >> On Fri, 06 Sep 2013 14:22:40 +0800, Axel Lin > >> wrote: > >> > >>> In current gpio_set_value() imple

Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-14 Thread Michael Trimarchi
Hi Axel On Sat, Sep 14, 2013 at 11:34 AM, Axel Lin wrote: > 2013/9/14 Albert ARIBAUD : >> Hi Axel, >> >> On Fri, 06 Sep 2013 14:22:40 +0800, Axel Lin >> wrote: >> >>> In current gpio_set_value() implementation, it always sets the gpio control >>> bit >>> no matter the value argument is 0 or 1.

Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-14 Thread Axel Lin
2013/9/14 Albert ARIBAUD : > Hi Axel, > > On Fri, 06 Sep 2013 14:22:40 +0800, Axel Lin > wrote: > >> In current gpio_set_value() implementation, it always sets the gpio control >> bit >> no matter the value argument is 0 or 1. Thus the GPIOs never set to low. >> This patch fixes this bug. >> >> S

Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-14 Thread Michael Trimarchi
Hi Albert On Sat, Sep 14, 2013 at 11:10 AM, Albert ARIBAUD wrote: > Hi Axel, > > On Fri, 06 Sep 2013 14:22:40 +0800, Axel Lin > wrote: > >> In current gpio_set_value() implementation, it always sets the gpio control >> bit >> no matter the value argument is 0 or 1. Thus the GPIOs never set to l

Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-14 Thread Albert ARIBAUD
Hi Axel, On Fri, 06 Sep 2013 14:22:40 +0800, Axel Lin wrote: > In current gpio_set_value() implementation, it always sets the gpio control > bit > no matter the value argument is 0 or 1. Thus the GPIOs never set to low. > This patch fixes this bug. > > Signed-off-by: Axel Lin > Acked-by: Stef

[U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013-09-05 Thread Axel Lin
In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value argument is 0 or 1. Thus the GPIOs never set to low. This patch fixes this bug. Signed-off-by: Axel Lin Acked-by: Stefan Roese Reviewed-by: Vipin Kumar --- This patch was sent on http://lists.de