Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201206090148.40933.ma...@denx.de> you wrote: > > > Multiplication being commutative, I see zero effect in this patch? > > > > Well, not in every algebraic system. It has zero effect, it's only > > about correctness [1]. Will applying th

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Wolfgang Denk
Dear Marek Vasut, In message <201206090148.40933.ma...@denx.de> you wrote: > > > Multiplication being commutative, I see zero effect in this patch? > > Well, not in every algebraic system. It has zero effect, it's only about > correctness [1]. Will applying this break anything? In which way

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Marek Vasut
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1339176514-13137-1-git-send-email-ma...@denx.de> you wrote: > > -#define kzalloc(size, flags) calloc(size, 1) > > +#define kzalloc(size, flags) calloc(1, size) > > Does this make any practical difference? > > I mean, are you aw

Re: [U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Wolfgang Denk
Dear Marek Vasut, In message <1339176514-13137-1-git-send-email-ma...@denx.de> you wrote: > > -#define kzalloc(size, flags) calloc(size, 1) > +#define kzalloc(size, flags) calloc(1, size) Does this make any practical difference? I mean, are you aware of any problem that gets fixed by this patch

[U-Boot] [PATCH RESEND] Fix misuse of calloc() in linux/compat.h header

2012-06-08 Thread Marek Vasut
Quote from the manpage: [...] void *calloc(size_t nmemb, size_t size); [...] DESCRIPTION [...] The calloc() function allocates memory for an array of nmemb elements of size bytes each and returns a pointer to the allocated memory. The memory is set to zero. If nmemb