Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-07 Thread Wolfgang Denk
Dear "kevin.morf...@fearnside-systems.co.uk", In message <4b6ec9d5.6060...@fearnside-systems.co.uk> you wrote: > > Patches 1 and 2 contain only white-space changes and patch 3 contains > only code style changes (moving external function prototypes to header > files, removing unused code, making l

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-07 Thread kevin.morf...@fearnside-systems.co.uk
On 07/02/2010 13:38, Minkyu Kang wrote: > Dear Wolfgang and kevin, > > On 6 February 2010 23:24, Wolfgang Denk wrote: >> Dear Minkyu Kang, >> >> In message<1f3430fb1002060418ydd28583sb6051dd1517fa...@mail.gmail.com> you >> wrote: >>> Changes the names of the s3c24x0 register struct member

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-07 Thread Minkyu Kang
Dear Wolfgang and kevin, On 6 February 2010 23:24, Wolfgang Denk wrote: > Dear Minkyu Kang, > > In message <1f3430fb1002060418ydd28583sb6051dd1517fa...@mail.gmail.com> you > wrote: >> >> > Changes the names of the s3c24x0 register struct members from upper-case >> > to lower-case. > ... >> Sorry

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Wolfgang Denk
Dear Tom, In message <4b6d9a3d.5090...@windriver.com> you wrote: > > > It was done automatically using Lindent but I had to do some manual > > tidying up because Lindent doesn't always get things right. > > Maybe a good way to spit the patch is > 1. Lindent > 2. Manual > So reviewer could spend m

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Wolfgang Denk
Dear "kevin.morf...@fearnside-systems.co.uk", In message <4b6d8128.5000...@fearnside-systems.co.uk> you wrote: > > > I think this should be merged into a single patch. > > OK. It'll be about 140K though so I'llput it on a web site. Just post it. I will check and eventually ACK it. > OK, it's q

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Tom
kevin.morf...@fearnside-systems.co.uk wrote: > > > On 06/02/2010 16:35, Tom wrote: >> kevin.morf...@fearnside-systems.co.uk wrote: >>> >>> >>> On 06/02/2010 15:14, Tom wrote: kevin.morf...@fearnside-systems.co.uk wrote: > Hi Wolfgang > > On 06/02/2010 14:26, Wolfgang Denk wrote:

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread kevin.morf...@fearnside-systems.co.uk
On 06/02/2010 16:35, Tom wrote: > kevin.morf...@fearnside-systems.co.uk wrote: >> >> >> On 06/02/2010 15:14, Tom wrote: >>> kevin.morf...@fearnside-systems.co.uk wrote: Hi Wolfgang On 06/02/2010 14:26, Wolfgang Denk wrote: > Dear "kevin.morf...@fearnside-systems.co.uk", > >

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Tom
kevin.morf...@fearnside-systems.co.uk wrote: > > > On 06/02/2010 15:14, Tom wrote: >> kevin.morf...@fearnside-systems.co.uk wrote: >>> Hi Wolfgang >>> >>> On 06/02/2010 14:26, Wolfgang Denk wrote: Dear "kevin.morf...@fearnside-systems.co.uk", In message<4b6d687f.2060...@fearnside-s

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread kevin.morf...@fearnside-systems.co.uk
On 06/02/2010 15:14, Tom wrote: > kevin.morf...@fearnside-systems.co.uk wrote: >> Hi Wolfgang >> >> On 06/02/2010 14:26, Wolfgang Denk wrote: >>> Dear "kevin.morf...@fearnside-systems.co.uk", >>> >>> In message<4b6d687f.2060...@fearnside-systems.co.uk> you wrote: The patches are split so t

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Tom
kevin.morf...@fearnside-systems.co.uk wrote: > Hi Wolfgang > > On 06/02/2010 14:26, Wolfgang Denk wrote: >> Dear "kevin.morf...@fearnside-systems.co.uk", >> >> In message<4b6d687f.2060...@fearnside-systems.co.uk> you wrote: >>> The patches are split so that each patch makes only one type of chang

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread kevin.morf...@fearnside-systems.co.uk
Hi Wolfgang On 06/02/2010 14:26, Wolfgang Denk wrote: > Dear "kevin.morf...@fearnside-systems.co.uk", > > In message<4b6d687f.2060...@fearnside-systems.co.uk> you wrote: >> >> The patches are split so that each patch makes only one type of change, >> so there's only one thing that needs to be che

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Wolfgang Denk
Dear "kevin.morf...@fearnside-systems.co.uk", In message <4b6d687f.2060...@fearnside-systems.co.uk> you wrote: > > The patches are split so that each patch makes only one type of change, > so there's only one thing that needs to be checked in each patch. > > - patches 1 and 2 only make white-spac

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Wolfgang Denk
Dear Minkyu Kang, In message <1f3430fb1002060418ydd28583sb6051dd1517fa...@mail.gmail.com> you wrote: > > > Changes the names of the s3c24x0 register struct members from upper-case > > to lower-case. ... > Sorry for late reply. > I tried to review your patch series, > but your patch is too confus

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread kevin.morf...@fearnside-systems.co.uk
Hi Minkyu On 06/02/2010 12:18, Minkyu Kang wrote: > Dear kevin.morfitt > > 2009/12/29 kevin.morf...@fearnside-systems.co.uk > : >> Changes the names of the s3c24x0 register struct members from upper-case >> to lower-case. >> >> Signed-off-by: Kevin Morfitt >> --- >> >> checkpatch.pl reports no err

Re: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case

2010-02-06 Thread Minkyu Kang
Dear kevin.morfitt 2009/12/29 kevin.morf...@fearnside-systems.co.uk : > Changes the names of the s3c24x0 register struct members from upper-case > to lower-case. > > Signed-off-by: Kevin Morfitt > --- > > checkpatch.pl reports no errors. MAKEALL ARM9 reports no new warnings > or errors. > > Note