Re: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-05-04 Thread Hans de Goede
Hi, On 05/02/2015 04:03 PM, Ian Campbell wrote: On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote: + if (hccr == (void *)SUNXI_USB1_BASE) { + priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0; + priv->phy_index = 1; Inferring these from the base addre

Re: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-05-02 Thread Ian Campbell
On Sat, 2015-05-02 at 15:03 +0100, Ian Campbell wrote: I see I missed v2, oh well, this bit of code looks the same AFAICT. > On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote: > > + if (hccr == (void *)SUNXI_USB1_BASE) { > > + priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0;

Re: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-05-02 Thread Ian Campbell
On Thu, 2015-04-30 at 16:35 +0200, Hans de Goede wrote: > + if (hccr == (void *)SUNXI_USB1_BASE) { > + priv->ahb_gate_mask = 1 << AHB_GATE_OFFSET_USB_EHCI0; > + priv->phy_index = 1; Inferring these from the base address is a bit unfortunate, should we not get told this

Re: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-05-01 Thread Hans de Goede
Hi, On 01-05-15 06:12, Simon Glass wrote: Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: Convert sunxi-boards which use the sunxi-ehci code to the driver-model. Signed-off-by: Hans de Goede --- board/sunxi/Kconfig | 3 ++ drivers/usb/host/ehci-sunxi.c | 95 ++

Re: [U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-04-30 Thread Simon Glass
Hi Hans, On 30 April 2015 at 08:35, Hans de Goede wrote: > Convert sunxi-boards which use the sunxi-ehci code to the driver-model. > > Signed-off-by: Hans de Goede > --- > board/sunxi/Kconfig | 3 ++ > drivers/usb/host/ehci-sunxi.c | 95 > ++-

[U-Boot] [PATCH 8/8] sunxi: ehci: Convert to the driver-model

2015-04-30 Thread Hans de Goede
Convert sunxi-boards which use the sunxi-ehci code to the driver-model. Signed-off-by: Hans de Goede --- board/sunxi/Kconfig | 3 ++ drivers/usb/host/ehci-sunxi.c | 95 ++- 2 files changed, 69 insertions(+), 29 deletions(-) diff --git a/board/s