Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-14 Thread Marek Vasut
Dear Otavio Salvador, > On Sat, May 12, 2012 at 8:40 PM, Otavio Salvador > > wrote: > > +++ b/arch/arm/include/asm/arch-mxs/regs-apbh.h > > @@ -30,142 +30,142 @@ > > My idea is to have a regs-apbh-mx28.h and regs-apbh-mx23.h file. But > the macro is mxs_... as it has same structure for mx28 and

Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-14 Thread Otavio Salvador
On Sat, May 12, 2012 at 8:40 PM, Otavio Salvador wrote: > +++ b/arch/arm/include/asm/arch-mxs/regs-apbh.h > @@ -30,142 +30,142 @@ My idea is to have a regs-apbh-mx28.h and regs-apbh-mx23.h file. But the macro is mxs_... as it has same structure for mx28 and mx23. -- Otavio Salvador             

Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-14 Thread Marek Vasut
Dear Otavio Salvador, > On Sun, May 13, 2012 at 3:46 PM, Marek Vasut wrote: > >> From what I read from mx23 datasheet it is. > > > > From what I saw two days ago in the LAKML it isn't ... compare > > HW_APBH_CH0_SEMA for instance ;-) Check drivers/dma/mxs-dma.c in Linux > > for example. > > Fro

Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-14 Thread Otavio Salvador
On Sun, May 13, 2012 at 3:46 PM, Marek Vasut wrote: >> From what I read from mx23 datasheet it is. > > From what I saw two days ago in the LAKML it isn't ... compare > HW_APBH_CH0_SEMA > for instance ;-) Check drivers/dma/mxs-dma.c in Linux for example. >From what I see the offsets are different

Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-13 Thread Marek Vasut
Dear Otavio Salvador, > On Sun, May 13, 2012 at 2:15 PM, Marek Vasut wrote: > >> As the register accessing mode is the same for all i.MXS SoCs we ought > >> to use 'mxs' prefix intead of 'mx28'. > > > > Are you _SURE_ the register offsets are the same on mx233 and mx28? For > > example for DMA?

Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-13 Thread Otavio Salvador
On Sun, May 13, 2012 at 2:15 PM, Marek Vasut wrote: >> As the register accessing mode is the same for all i.MXS SoCs we ought >> to use 'mxs' prefix intead of 'mx28'. >> > > Are you _SURE_ the register offsets are the same on mx233 and mx28? For > example > for DMA? >From what I read from mx23 d

Re: [U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-13 Thread Marek Vasut
Dear Otavio Salvador, > As the register accessing mode is the same for all i.MXS SoCs we ought > to use 'mxs' prefix intead of 'mx28'. > Are you _SURE_ the register offsets are the same on mx233 and mx28? For example for DMA? Best regards, Marek Vasut __

[U-Boot] [PATCH 8/8] mxs: prefix register acessor macros with 'mxs' prefix

2012-05-12 Thread Otavio Salvador
As the register accessing mode is the same for all i.MXS SoCs we ought to use 'mxs' prefix intead of 'mx28'. Signed-off-by: Otavio Salvador --- arch/arm/cpu/arm926ejs/mxs/clock.c |4 +- arch/arm/cpu/arm926ejs/mxs/iomux.c |6 +- arch/arm/cpu/arm926ejs/mxs/mx28.c